Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: src/objects.h

Issue 1453583002: Sort names in JSObject::CollectOwnPropertyNames. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/key-accumulator.h ('k') | src/objects.cc » ('j') | src/objects.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index d30bda2ad3986abe8c6217f60ce1059e15e0c541..7a8010ac1740bc511c0a28d889c13e3699cd59ba 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -2257,8 +2257,8 @@ class JSObject: public JSReceiver {
// index. Returns the number of properties added.
int GetOwnPropertyNames(FixedArray* storage, int index,
PropertyAttributes filter = NONE);
- int CollectOwnPropertyNames(KeyAccumulator* keys,
- PropertyAttributes filter = NONE);
+ void CollectOwnPropertyNames(KeyAccumulator* keys,
+ PropertyAttributes filter = NONE);
// Returns the number of properties on this object filtering out properties
// with the specified attributes (ignoring interceptors).
@@ -3401,7 +3401,7 @@ class Dictionary: public HashTable<Derived, Shape, Key> {
int CopyKeysTo(FixedArray* storage, int index, PropertyAttributes filter,
SortMode sort_mode);
// Collect the unsorted keys into the given KeyAccumulator.
- int CollectKeysTo(KeyAccumulator* keys, PropertyAttributes filter);
+ void CollectKeysTo(KeyAccumulator* keys, PropertyAttributes filter);
// Copies enumerable keys to preallocated fixed array.
void CopyEnumKeysTo(FixedArray* storage);
« no previous file with comments | « src/key-accumulator.h ('k') | src/objects.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698