Sort names in JSObject::CollectOwnPropertyNames.

Sort names in JSObject::CollectOwnPropertyNames.

R=cbruni, rossberg
BUG=

Committed: https://crrev.com/8e5840e19b07d62acf3252320b68602e29909614
Cr-Commit-Position: refs/heads/master@{#32063}

[adamk, 2015-11-17 01:06:54]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2015-11-17 01:06:54]

Does this fix https://code.google.com/p/v8/issues/detail?id=3056? If so a
regression test would be good.

[neis, 2015-11-17 01:10:48]

On 2015/11/17 01:06:54, adamk wrote:
> Does this fix https://code.google.com/p/v8/issues/detail?id=3056? If so a
> regression test would be good.

No, unfortunately that's a separate bug.

[Camillo Bruni, 2015-11-17 10:02:52]

LGMT with minor nit

https://codereview.chromium.org/1453583002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1453583002/diff/1/src/objects.cc#newcode16908
src/objects.cc:16908: keys->isolate()->factory()->NewFixedArray(capacity);
I think NumberOfElements() would be better here no? Capacity should be quite an
overestimate for Dictionaries. (I think it was me who even added that piece of
code in the first place :)

[neis, 2015-11-17 19:32:22]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 19:32:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1453583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1453583002/40001

[neis, 2015-11-17 19:36:04]

On 2015/11/17 10:02:52, cbruni wrote:
> LGMT with minor nit
> 
> https://codereview.chromium.org/1453583002/diff/1/src/objects.cc
> File src/objects.cc (right):
> 
> https://codereview.chromium.org/1453583002/diff/1/src/objects.cc#newcode16908
> src/objects.cc:16908: keys->isolate()->factory()->NewFixedArray(capacity);
> I think NumberOfElements() would be better here no? Capacity should be quite
an
> overestimate for Dictionaries. (I think it was me who even added that piece of
> code in the first place :)

Thanks, good point.

[neis, 2015-11-17 19:36:22]

Description was changed from

==========
Sort names in JSObject::CollectOwnPropertyNames.

With this, I can reland the Reflect.ownKeys CL.

R=cbruni, rossberg
BUG=
==========

to

==========
Sort names in JSObject::CollectOwnPropertyNames.

R=cbruni, rossberg
BUG=
==========

[commit-bot: I haz the power, 2015-11-17 19:51:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 19:51:33]

Dry run: This issue passed the CQ dry run.

[neis, 2015-11-17 19:52:22]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2015-11-17 19:52:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1453583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1453583002/40001

[commit-bot: I haz the power, 2015-11-17 19:52:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 19:52:31]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[adamk, 2015-11-18 00:04:56]

lgtm

[adamk, 2015-11-18 00:05:06]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2015-11-18 00:05:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1453583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1453583002/40001

[commit-bot: I haz the power, 2015-11-18 00:06:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-18 00:07:25]

Patchset 3 (id:??) landed as
https://crrev.com/8e5840e19b07d62acf3252320b68602e29909614
Cr-Commit-Position: refs/heads/master@{#32063}