Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 145353017: Update HPACK implementation to draft 05 (Closed)

Created:
6 years, 10 months ago by Johnny
Modified:
6 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Update HPACK implementation to draft 05 In particular: - Switch to 1-based indexing. - Use 0 instead of -1 as the "invalid index" value. - Add "host" header to the static table. - Add HpackEncodingContext::GetMutableEntryCount() function. This lands server change 60493594 by akalin. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -147 lines) Patch
M net/spdy/hpack_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_encoding_context.h View 3 chunks +10 lines, -6 lines 0 comments Download
M net/spdy/hpack_encoding_context.cc View 6 chunks +93 lines, -82 lines 0 comments Download
M net/spdy/hpack_encoding_context_test.cc View 5 chunks +33 lines, -26 lines 0 comments Download
M net/spdy/hpack_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_header_table.h View 3 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/hpack_header_table.cc View 4 chunks +12 lines, -9 lines 0 comments Download
M net/spdy/hpack_header_table_test.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M net/spdy/hpack_output_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_string_util.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Johnny
First of Fred's HPACK changes.
6 years, 10 months ago (2014-01-29 22:32:18 UTC) #1
Ryan Hamilton
lgtm
6 years, 10 months ago (2014-01-29 22:36:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/145353017/1
6 years, 10 months ago (2014-01-29 22:43:39 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253912
6 years, 10 months ago (2014-01-30 01:49:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/145353017/1
6 years, 10 months ago (2014-01-30 01:56:10 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 06:20:49 UTC) #6
Message was sent while issue was closed. 
Change committed as 247851

Powered by Google App Engine
This is Rietveld 408576698