Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: net/spdy/hpack_header_table.h

Issue 145353017: Update HPACK implementation to draft 05 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/hpack_entry.h ('k') | net/spdy/hpack_header_table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/hpack_header_table.h
diff --git a/net/spdy/hpack_header_table.h b/net/spdy/hpack_header_table.h
index 87758d5f17a2a51850aa830d3df8f15d6b03b9a8..a97d4a7f6b93bc7a38e0428fb889f2f07d460b48 100644
--- a/net/spdy/hpack_header_table.h
+++ b/net/spdy/hpack_header_table.h
@@ -17,7 +17,7 @@
namespace net {
// All section references below are to
-// http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-04
+// http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-05
// .
// A data structure for both the header table (described in 3.1.2) and
@@ -36,10 +36,10 @@ class NET_EXPORT_PRIVATE HpackHeaderTable {
// Returns the total number of entries.
uint32 GetEntryCount() const;
- // The given index must be >= 0 and < GetEntryCount().
+ // The given index must be >= 1 and <= GetEntryCount().
const HpackEntry& GetEntry(uint32 index) const;
- // The given index must be >= 0 and < GetEntryCount().
+ // The given index must be >= 1 and <= GetEntryCount().
HpackEntry* GetMutableEntry(uint32 index);
// Sets the maximum size of the header table, evicting entries if
@@ -49,12 +49,12 @@ class NET_EXPORT_PRIVATE HpackHeaderTable {
// The given entry must not be one from the header table, since it
// may get evicted. Tries to add the given entry to the header
// table, evicting entries if necessary as described in 3.3.3. index
- // will be filled in with the index of the added entry, or -1 if the
+ // will be filled in with the index of the added entry, or 0 if the
// entry could not be added. removed_referenced_indices will be
// filled in with the indices of any removed entries that were in
// the reference set.
void TryAddEntry(const HpackEntry& entry,
- int32* index,
+ uint32* index,
std::vector<uint32>* removed_referenced_indices);
private:
« no previous file with comments | « net/spdy/hpack_entry.h ('k') | net/spdy/hpack_header_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698