Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 145353004: Build HTMLFormElement::m_associatedElements lazily (Closed)

Created:
6 years, 11 months ago by tkent
Modified:
6 years, 10 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Visibility:
Public.

Description

Build HTMLFormElement::m_associatedElements lazily HTMLFormElement::associate() and disassociate() don't update m_associatedElements synchronously, and we build it by traversing a DOM tree on demand. The code becomes simpler and we don't need complex functions like formElementIndexWithFormAttribute and formElementIndex any more. Difference from r165846: Fixed a crash when a FORM with multiple elements magically associated by HTML parser is detach from the document. This contains a test for the crash. BUG=334556, 338764 TEST=none; no user-visible behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166029

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -108 lines) Patch
M LayoutTests/fast/forms/form-associated-element.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/IdTargetObserverRegistry.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/IdTargetObserverRegistry.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFormElement.h View 3 chunks +5 lines, -6 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 5 chunks +56 lines, -102 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tkent
Keishi, would you review this please?
6 years, 11 months ago (2014-01-27 09:10:32 UTC) #1
keishi
lgtm
6 years, 11 months ago (2014-01-27 10:57:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/145353004/1
6 years, 11 months ago (2014-01-27 11:16:37 UTC) #3
commit-bot: I haz the power
Change committed as 165846
6 years, 11 months ago (2014-01-27 11:20:42 UTC) #4
gavinp
On 2014/01/27 11:20:42, I haz the power (commit-bot) wrote: > Change committed as 165846 Reverted, ...
6 years, 10 months ago (2014-01-28 18:37:06 UTC) #5
tkent
https://codereview.chromium.org/145353004/diff/1/Source/core/html/HTMLFormElement.cpp File Source/core/html/HTMLFormElement.cpp (right): https://codereview.chromium.org/145353004/diff/1/Source/core/html/HTMLFormElement.cpp#newcode140 Source/core/html/HTMLFormElement.cpp:140: notifyFormRemovedFromTree(associatedElements(), root); We need to pass a copy of ...
6 years, 10 months ago (2014-01-29 01:02:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/145353004/100001
6 years, 10 months ago (2014-01-29 02:30:55 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=9650
6 years, 10 months ago (2014-01-29 09:30:51 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-29 09:32:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/145353004/100001
6 years, 10 months ago (2014-01-29 09:55:14 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-29 13:17:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/145353004/100001
6 years, 10 months ago (2014-01-29 13:19:06 UTC) #12
commit-bot: I haz the power
Change committed as 166029
6 years, 10 months ago (2014-01-29 16:20:17 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 16:20:37 UTC) #14
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698