Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp

Issue 1453473002: FWL refcounts never incremented (part 2). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Rebased Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp ('k') | xfa/src/fwl/src/basewidget/fwl_scrollbarimp.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp
diff --git a/xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp b/xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp
index 8ddd93d272e2bbefc96eb05d7338a4d1f52ff222..e775861749c9fca60c50a6e4f063c577555ac1b0 100644
--- a/xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp
+++ b/xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp
@@ -9,24 +9,21 @@
#include "../core/include/fwl_noteimp.h"
#include "../core/include/fwl_widgetimp.h"
#include "include/fwl_pushbuttonimp.h"
-FWL_ERR IFWL_PushButton::Initialize(const CFWL_WidgetImpProperties& properties,
- IFWL_Widget* pOuter) {
+
+// static
+IFWL_PushButton* IFWL_PushButton::Create(
+ const CFWL_WidgetImpProperties& properties,
+ IFWL_Widget* pOuter) {
+ IFWL_PushButton* pPushButton = new IFWL_PushButton;
CFWL_PushButtonImp* pPushButtonImpl =
new CFWL_PushButtonImp(properties, pOuter);
- SetImpl(pPushButtonImpl);
- pPushButtonImpl->SetInterface(this);
- return pPushButtonImpl->Initialize();
+ pPushButton->SetImpl(pPushButtonImpl);
+ pPushButtonImpl->SetInterface(pPushButton);
+ return pPushButton;
}
IFWL_PushButton::IFWL_PushButton() {
}
-CFWL_PushButtonImp::CFWL_PushButtonImp(IFWL_Widget* pOuter)
- : CFWL_WidgetImp(pOuter),
- m_bBtnDown(FALSE),
- m_dwTTOStyles(FDE_TTOSTYLE_SingleLine),
- m_iTTOAlign(FDE_TTOALIGNMENT_Center) {
- m_rtClient.Set(0, 0, 0, 0);
- m_rtCaption.Set(0, 0, 0, 0);
-}
+
CFWL_PushButtonImp::CFWL_PushButtonImp(
const CFWL_WidgetImpProperties& properties,
IFWL_Widget* pOuter)
« no previous file with comments | « xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp ('k') | xfa/src/fwl/src/basewidget/fwl_scrollbarimp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698