Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1981)

Unified Diff: xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp

Issue 1453473002: FWL refcounts never incremented (part 2). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Rebased Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp
diff --git a/xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp b/xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp
index 7c02052f743539132c98843b6920efe11ffadfe6..8650b5545ae5abd2e73895dfe256421c468b5627 100644
--- a/xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp
+++ b/xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp
@@ -9,25 +9,20 @@
#include "../core/include/fwl_noteimp.h"
#include "../core/include/fwl_widgetimp.h"
#include "include/fwl_pictureboximp.h"
-IFWL_PictureBox::IFWL_PictureBox() {
-}
-FWL_ERR IFWL_PictureBox::Initialize(const CFWL_WidgetImpProperties& properties,
- IFWL_Widget* pOuter) {
+
+// static
+IFWL_PictureBox* IFWL_PictureBox::Create(
+ const CFWL_WidgetImpProperties& properties,
+ IFWL_Widget* pOuter) {
+ IFWL_PictureBox* pPictureBox = new IFWL_PictureBox;
CFWL_PictureBoxImp* pPictureBoxImpl =
new CFWL_PictureBoxImp(properties, pOuter);
- SetImpl(pPictureBoxImpl);
- pPictureBoxImpl->SetInterface(this);
- return pPictureBoxImpl->Initialize();
-}
-CFWL_PictureBoxImp::CFWL_PictureBoxImp(IFWL_Widget* pOuter)
- : CFWL_WidgetImp(pOuter),
- m_bTop(FALSE),
- m_bVCenter(FALSE),
- m_bButton(FALSE) {
- m_rtClient.Reset();
- m_rtImage.Reset();
- m_matrix.SetIdentity();
+ pPictureBox->SetImpl(pPictureBoxImpl);
+ pPictureBoxImpl->SetInterface(pPictureBox);
+ return pPictureBox;
}
+IFWL_PictureBox::IFWL_PictureBox() {}
+
CFWL_PictureBoxImp::CFWL_PictureBoxImp(
const CFWL_WidgetImpProperties& properties,
IFWL_Widget* pOuter)
« no previous file with comments | « xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.cpp ('k') | xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698