xfa/src/fwl/src/lightwidget/widget.cpp - Issue 1453473002: FWL refcounts never incremented (part 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fwl/src/lightwidget/widget.cpp

Issue 1453473002: FWL refcounts never incremented (part 2). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fwl/src/lightwidget/widget.cpp

diff --git a/xfa/src/fwl/src/lightwidget/widget.cpp b/xfa/src/fwl/src/lightwidget/widget.cpp

index 283aed0e2f1f269713894b58c57fc598f8f7111b..f3061911736acf79a0e2d04f5f9adac9e3982cd0 100644

--- a/xfa/src/fwl/src/lightwidget/widget.cpp

+++ b/xfa/src/fwl/src/lightwidget/widget.cpp

@@ -26,11 +26,6 @@ FX_DWORD CFWL_Widget::Release() {

}

return dwRef - 1;

}

-CFWL_Widget* CFWL_Widget::Retain() {

- _FWL_RETURN_VALUE_IF_FAIL(m_pImp, NULL);

- m_pImp->Retain();

- return this;

FX_DWORD CFWL_Widget::GetRefCount() const {

_FWL_RETURN_VALUE_IF_FAIL(m_pImp, 1);

return m_pImp->GetRefCount();