FWL refcounts never incremented (part 2).

xfa/include/fwl/core/fwl_note.h

Index: xfa/include/fwl/core/fwl_note.h
diff --git a/xfa/include/fwl/core/fwl_note.h b/xfa/include/fwl/core/fwl_note.h
index 66366e92e44da5081f3778fdbed48e520dc4b1cd..9ea20915313aff2120486bbb0cadcdaf8b033a2a 100644
--- a/xfa/include/fwl/core/fwl_note.h
+++ b/xfa/include/fwl/core/fwl_note.h
@@ -132,7 +132,7 @@ class CFWL_Note {
   }
   virtual IFWL_Target* Retain() {

[Tom Sepez, 2015/11/16 20:07:11]

Doesn't override anything, provides its own m_dwRefcount.  I don't think these
objects belong in the same FWL hierarchy as the others, do they?

[Lei Zhang, 2015/11/16 20:34:49]

This is the root for a different class hierachy. I suspect this is a copy+paste
error from one of the other xfa/ Retain() methods.

     m_dwRefCount++;
-    return (IFWL_Target*)this;
+    return (IFWL_Target*)this;  // Illegal cast.
   }
   virtual FWL_ERR GetClassName(CFX_WideString& wsClass) const {
     wsClass = L"CFWL_Note";