Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: xfa/src/fwl/src/core/fwl_targetimp.cpp

Issue 1453473002: FWL refcounts never incremented (part 2). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/src/fwl/src/core/fwl_targetimp.cpp
diff --git a/xfa/src/fwl/src/core/fwl_targetimp.cpp b/xfa/src/fwl/src/core/fwl_targetimp.cpp
index cd9bf811a8b128c95a6e87bbbb1233232f16d916..2aecd10e8f5966cc1fe9b6112dd74a12ee0ade5c 100644
--- a/xfa/src/fwl/src/core/fwl_targetimp.cpp
+++ b/xfa/src/fwl/src/core/fwl_targetimp.cpp
@@ -14,9 +14,6 @@ FX_DWORD IFWL_Target::Release() {
}
return dwRef;
}
-IFWL_Target* IFWL_Target::Retain() {
- return ((CFWL_Target*)m_pData)->Retain();
-}
FX_DWORD IFWL_Target::GetRefCount() const {
return ((CFWL_Target*)m_pData)->GetRefCount();
}
@@ -46,10 +43,6 @@ FX_DWORD CFWL_Target::Release() {
}
return dwRet;
}
-IFWL_Target* CFWL_Target::Retain() {
- m_dwRefCount++;
- return (IFWL_Target*)this;
-}
FX_DWORD CFWL_Target::GetRefCount() const {
return m_dwRefCount;
}

Powered by Google App Engine
This is Rietveld 408576698