Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1453433002: Move diagnostics to `diagnostics` domain (#24931). (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, devoncarew
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move diagnostics to `diagnostics` domain (#24931). Still flagged `experimental` so no docs created. See: https://github.com/dart-lang/sdk/issues/24931 BUG=24931 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/6d9cb5e48a8a55d0988c43ed52b0e20260c5c922

Patch Set 1 #

Patch Set 2 : master merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -224 lines) Patch
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 6 chunks +14 lines, -14 lines 0 comments Download
A + pkg/analysis_server/lib/src/domain_diagnostic.dart View 2 chunks +9 lines, -9 lines 0 comments Download
D pkg/analysis_server/lib/src/domain_experimental.dart View 1 chunk +0 lines, -95 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/test/domain_diagnostic_test.dart View 5 chunks +7 lines, -7 lines 0 comments Download
D pkg/analysis_server/test/domain_experimental_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/AnalysisServer.java View 2 chunks +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 1 month ago (2015-11-16 19:28:35 UTC) #2
Brian Wilkerson
I honestly don't understand the value of changing the name, but I don't have a ...
5 years, 1 month ago (2015-11-16 19:34:58 UTC) #3
pquitslund
5 years, 1 month ago (2015-11-16 22:10:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6d9cb5e48a8a55d0988c43ed52b0e20260c5c922 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698