Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: pkg/analysis_server/lib/src/domain_diagnostic.dart

Issue 1453433002: Move diagnostics to `diagnostics` domain (#24931). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: master merge Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/domain_diagnostic.dart
diff --git a/pkg/analysis_server/lib/src/domain_experimental.dart b/pkg/analysis_server/lib/src/domain_diagnostic.dart
similarity index 84%
rename from pkg/analysis_server/lib/src/domain_experimental.dart
rename to pkg/analysis_server/lib/src/domain_diagnostic.dart
index 0e34409e42e9208008e9f7f75920a0b28fdc443c..e6c08c4e1664495f8cb0144531e957e7b4f353db 100644
--- a/pkg/analysis_server/lib/src/domain_experimental.dart
+++ b/pkg/analysis_server/lib/src/domain_diagnostic.dart
@@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library src.domain_experimental;
+library src.domain_diagnostic;
import 'dart:collection';
import 'dart:core' hide Resource;
@@ -57,34 +57,34 @@ ContextData extractData(AnalysisContext context) {
exceptions.toList());
}
-/// Instances of the class [ExperimentalDomainHandler] implement a
-/// [RequestHandler] that handles requests in the `experimental` domain.
-class ExperimentalDomainHandler implements RequestHandler {
+/// Instances of the class [DiagnosticDomainHandler] implement a
+/// [RequestHandler] that handles requests in the `diagnostic` domain.
+class DiagnosticDomainHandler implements RequestHandler {
/// The name of the request used to get diagnostic information.
- static const String EXPERIMENTAL_DIAGNOSTICS = 'experimental.getDiagnostics';
+ static const String DIAGNOSTICS = 'diagnostic.getDiagnostics';
/// The analysis server that is using this handler to process requests.
final AnalysisServer server;
/// Initialize a newly created handler to handle requests for the given
/// [server].
- ExperimentalDomainHandler(this.server);
+ DiagnosticDomainHandler(this.server);
- /// Answer the `experimental.diagnostics` request.
+ /// Answer the `diagnostic.diagnostics` request.
Response computeDiagnostics(Request request) {
List<ContextData> infos = <ContextData>[];
server.folderMap.forEach((Folder folder, AnalysisContext context) {
infos.add(extractData(context));
});
- return new ExperimentalGetDiagnosticsResult(infos).toResponse(request.id);
+ return new DiagnosticGetDiagnosticsResult(infos).toResponse(request.id);
}
@override
Response handleRequest(Request request) {
try {
String requestName = request.method;
- if (requestName == EXPERIMENTAL_DIAGNOSTICS) {
+ if (requestName == DIAGNOSTICS) {
return computeDiagnostics(request);
}
} on RequestFailure catch (exception) {
« no previous file with comments | « pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart ('k') | pkg/analysis_server/lib/src/domain_experimental.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698