chrome/browser/ui/app_list/extension_app_item.cc - Issue 14533006: Drag and drop between app list and launcher - First patch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/extension_app_item.cc

Issue 14533006: Drag and drop between app list and launcher - First patch (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adressed nits (and a broken unit test and a git hiccup) Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/extension_app_item.cc

diff --git a/chrome/browser/ui/app_list/extension_app_item.cc b/chrome/browser/ui/app_list/extension_app_item.cc

index 4cd4ff4a4b9dfd36e0ee0c6c10c241a7ec10a741..c210d169865e269d15962ab63d5c97523fd504d8 100644

--- a/chrome/browser/ui/app_list/extension_app_item.cc

+++ b/chrome/browser/ui/app_list/extension_app_item.cc

@@ -210,6 +210,7 @@ void ExtensionAppItem::Reload() {

UpdateIcon();

return;

}

+ SetAppId(extension->id());

benwells 2013/05/02 06:40:05 You should call SetAppId(extension_id) before the

Mr4D (OOO till 08-26) 2013/05/03 00:23:17 Done.

SetTitle(extension->name());

LoadImage(extension);

}