Drag and drop between app list and launcher - First patch

chrome/browser/ui/app_list/extension_app_item.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/extension_app_item.h"
 
 #include "base/prefs/pref_service.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/extensions/context_menu_matcher.h"
 #include "chrome/browser/extensions/extension_prefs.h"
@@ skipping 192 matching lines @@
 
 void ExtensionAppItem::Reload() {
   const Extension* extension = GetExtension();
   bool is_installing = !extension;
   SetIsInstalling(is_installing);
   if (is_installing) {
     SetTitle(extension_name_);
     UpdateIcon();
     return;
   }
+  SetAppId(extension->id());

[benwells, 2013/05/02 06:40:05]

You should call SetAppId(extension_id) before the if block, so this will allow
pinning of apps that are currently installing.

[Mr4D (OOO till 08-26), 2013/05/03 00:23:17]

Done.

   SetTitle(extension->name());
   LoadImage(extension);
 }
 
 syncer::StringOrdinal ExtensionAppItem::GetPageOrdinal() const {
   return GetExtensionSorting(profile_)->GetPageOrdinal(extension_id_);
 }
 
 syncer::StringOrdinal ExtensionAppItem::GetAppLaunchOrdinal() const {
   return GetExtensionSorting(profile_)->GetAppLaunchOrdinal(extension_id_);
@@ skipping 353 matching lines @@
     context_menu_model_->AddItemWithStringId(DETAILS,
                                              IDS_NEW_TAB_APP_DETAILS);
     context_menu_model_->AddItemWithStringId(UNINSTALL,
                                              is_platform_app_ ?
                                                  IDS_APP_LIST_UNINSTALL_ITEM :
                                                  IDS_EXTENSIONS_UNINSTALL);
   }
 
   return context_menu_model_.get();
 }