Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1453243005: Revert of Mark WebappSplashScreenIconTest#testShowSplashIcon as flaky (Closed)

Created:
5 years, 1 month ago by mlamouri (slow - plz ping)
Modified:
5 years, 1 month ago
Reviewers:
gone, dgn
CC:
chromium-reviews, mlamouri (slow - plz ping)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mark WebappSplashScreenIconTest#testShowSplashIcon as flaky (patchset #1 id:1 of https://codereview.chromium.org/1436163003/ ) Reason for revert: dfalcantara@ fixed a larger issue with web apps tests on N4 devices. Reverting this in case of his CL fixed the problem. Original issue's description: > Mark WebappSplashScreenIconTest#testShowSplashIcon as flaky > > Added in https://codereview.chromium.org/1414873004 > > TBR=dfalcantara@chromium.org > BUG=554929 > > Committed: https://crrev.com/567ee4cbb84855641304da750f4865b95eb18054 > Cr-Commit-Position: refs/heads/master@{#359304} TBR=dfalcantara@chromium.org,dgn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=554929 Committed: https://crrev.com/710d4ab0013c424ab259bdfebe63c85c13846722 Cr-Commit-Position: refs/heads/master@{#360636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mlamouri (slow - plz ping)
Created Revert of Mark WebappSplashScreenIconTest#testShowSplashIcon as flaky
5 years, 1 month ago (2015-11-19 19:01:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453243005/1
5 years, 1 month ago (2015-11-19 19:03:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 19:05:19 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 19:06:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/710d4ab0013c424ab259bdfebe63c85c13846722
Cr-Commit-Position: refs/heads/master@{#360636}

Powered by Google App Engine
This is Rietveld 408576698