Web app splash screen: add even moar tests.

Web app splash screen: add even moar tests.

Fixing some TODO related to tests and replace initial tests with
something more flexible.

BUG=None

Committed: https://crrev.com/baf4b814c7f6764d1eb43de3d7447427463e5b9a
Cr-Commit-Position: refs/heads/master@{#355621}

[mlamouri (slow - plz ping), 2015-10-20 18:40:23]

mlamouri@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[mlamouri (slow - plz ping), 2015-10-20 18:40:23]

PTAL.

[gone, 2015-10-20 19:07:34]

https://codereview.chromium.org/1414873004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
(right):

https://codereview.chromium.org/1414873004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java:427:
ViewGroup getSplashScreenForTest() {
er, maybe this and the one above should be ForTests().  getUrlBarForTests()
should be the one to follow because it came first.

https://codereview.chromium.org/1414873004/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenBackgroundColorTest.java
(right):

https://codereview.chromium.org/1414873004/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenBackgroundColorTest.java:33:
public void testShowBackgroundColor() {
Is it worth combining this test with the one right below it?  Starting up a new
Activity is relatively slow, and the individual tests do only one tiny thing.

https://codereview.chromium.org/1414873004/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java
(right):

https://codereview.chromium.org/1414873004/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java:26:
protected Intent createIntent() {
Actually, based on the offline chat, can this suite and the
WebappSplashScreenHomescreenIconTest be combined?  They use the exact same
Intent.

https://codereview.chromium.org/1414873004/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java:48:
assertEquals(512, drawable.getBitmap().getWidth());
Do we have to worry about rounding problems and densities for different testing
devices?

https://codereview.chromium.org/1414873004/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java
(left):

https://codereview.chromium.org/1414873004/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java:129:
public void testUsesMinWebappInfoIcons() {
do these tests get replaced by the other ones you added?

[mlamouri (slow - plz ping), 2015-10-21 15:15:21]

Comments applied. PTAL.

https://codereview.chromium.org/1414873004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
(right):

https://codereview.chromium.org/1414873004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java:427:
ViewGroup getSplashScreenForTest() {
On 2015/10/20 at 19:07:34, dfalcantara wrote:
> er, maybe this and the one above should be ForTests().  getUrlBarForTests()
should be the one to follow because it came first.

I will do that but ForTests() and ForTest() are used as often in Jav. Though
ForTests() is very rare in C++.

https://codereview.chromium.org/1414873004/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenBackgroundColorTest.java
(right):

https://codereview.chromium.org/1414873004/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenBackgroundColorTest.java:33:
public void testShowBackgroundColor() {
On 2015/10/20 at 19:07:34, dfalcantara wrote:
> Is it worth combining this test with the one right below it?  Starting up a
new Activity is relatively slow, and the individual tests do only one tiny
thing.

Done.

https://codereview.chromium.org/1414873004/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java
(right):

https://codereview.chromium.org/1414873004/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java:48:
assertEquals(512, drawable.getBitmap().getWidth());
On 2015/10/20 at 19:07:34, dfalcantara wrote:
> Do we have to worry about rounding problems and densities for different
testing devices?

getWidth() is density agnostic.

https://codereview.chromium.org/1414873004/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java
(left):

https://codereview.chromium.org/1414873004/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java:129:
public void testUsesMinWebappInfoIcons() {
On 2015/10/20 at 19:07:34, dfalcantara wrote:
> do these tests get replaced by the other ones you added?

Yes :)

[gone, 2015-10-21 17:21:25]

lgtm, but the bot seems unhappy.

[mlamouri (slow - plz ping), 2015-10-21 21:19:17]

On 2015/10/21 at 17:21:25, dfalcantara wrote:
> lgtm, but the bot seems unhappy.

The tests are passing locally. I will wait for the dependency to land and
investigate more if things are still broken.

[mlamouri (slow - plz ping), 2015-10-22 19:19:50]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-10-22 19:19:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1414873004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2015-10-22 19:20:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414873004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414873004/40001

[commit-bot: I haz the power, 2015-10-22 19:55:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-22 19:56:07]

Patchset 3 (id:??) landed as
https://crrev.com/baf4b814c7f6764d1eb43de3d7447427463e5b9a
Cr-Commit-Position: refs/heads/master@{#355621}