Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 145323005: Support MessageEventInit.ports sequences. (Closed)

Created:
6 years, 11 months ago by sof
Modified:
6 years, 11 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Support MessageEventInit.ports sequences. For MessageEvent constructor dictionaries, http://www.whatwg.org/specs/web-apps/current-work/multipage/comms.html#messageevent don't limit ourselves to array objects, but support the required sequence type. R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M LayoutTests/fast/events/constructors/message-event-constructor.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/events/constructors/message-event-constructor-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/V8Utilities.cpp View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
When you have a spare moment, please take a look.
6 years, 11 months ago (2014-01-23 15:17:33 UTC) #1
Inactive
lgtm
6 years, 11 months ago (2014-01-23 15:23:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/145323005/1
6 years, 11 months ago (2014-01-23 15:23:55 UTC) #3
haraken
LGTM2
6 years, 11 months ago (2014-01-23 15:24:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/145323005/1
6 years, 11 months ago (2014-01-23 18:21:05 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 20:04:16 UTC) #6
Message was sent while issue was closed.
Change committed as 165656

Powered by Google App Engine
This is Rietveld 408576698