Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: Source/bindings/v8/V8Utilities.cpp

Issue 145323005: Support MessageEventInit.ports sequences. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/events/constructors/message-event-constructor-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8Utilities.cpp
diff --git a/Source/bindings/v8/V8Utilities.cpp b/Source/bindings/v8/V8Utilities.cpp
index a2dc1548c3c9dd7ee9c6b173d1d346fa20332c41..7078d9a00ea3bef273cf66e3efe06138d3c762e5 100644
--- a/Source/bindings/v8/V8Utilities.cpp
+++ b/Source/bindings/v8/V8Utilities.cpp
@@ -121,10 +121,6 @@ bool getMessagePortArray(v8::Local<v8::Value> value, const String& propertyName,
ports.resize(0);
return true;
}
- if (!value->IsArray()) {
- throwTypeError(ExceptionMessages::notASequenceTypeProperty(propertyName), isolate);
- return false;
- }
bool success = false;
ports = toRefPtrNativeArray<MessagePort, V8MessagePort>(value, propertyName, isolate, &success);
return success;
@@ -136,10 +132,6 @@ bool getMessagePortArray(v8::Local<v8::Value> value, int argumentIndex, MessageP
ports.resize(0);
return true;
}
- if (!value->IsArray()) {
- throwTypeError(ExceptionMessages::notAnArrayTypeArgumentOrValue(argumentIndex), isolate);
- return false;
- }
bool success = false;
ports = toRefPtrNativeArray<MessagePort, V8MessagePort>(value, argumentIndex, isolate, &success);
return success;
« no previous file with comments | « LayoutTests/fast/events/constructors/message-event-constructor-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698