autofill: switch autofill_regexes to RE2 library

components/autofill/core/browser/form_field.cc

Index: components/autofill/core/browser/form_field.cc
diff --git a/components/autofill/core/browser/form_field.cc b/components/autofill/core/browser/form_field.cc
index 50d7e8a30a81cf74343e3656627695840085f9cf..d297ee0e34bee977fb70d7f858cde6045c5e2118 100644
--- a/components/autofill/core/browser/form_field.cc
+++ b/components/autofill/core/browser/form_field.cc
@@ -180,12 +180,12 @@ bool FormField::Match(const AutofillField* field,
                       const base::string16& pattern,
                       int match_type) {
   if ((match_type & FormField::MATCH_LABEL) &&
-      MatchesPattern(field->label, pattern)) {
+      MatchesPattern(field->label, base::UTF16ToASCII(pattern))) {

[Evan Stade, 2015/11/25 19:33:01]

Yes, Ilya's suggestion is good :) This code is not :(

should be base::UTF16ToUTF8

[Ilya Sherman, 2015/11/25 22:18:14]

Actually, there should not be any conversion here at all.  Instead, you should
make the |pattern| above also be an std::string, since that's what the patterns
start out as.

That said, Evan's comment is also worth keeping in mind: UTF16 is typically not
safe to convert to ASCII; instead, you should convert it to UTF8.  Again, this
sort of conversion shouldn't be needed at all for this CL; but it's a good thing
to keep in mind for the future.

[tfarina, 2015/11/26 00:56:34]

Done. Though the changes are scaling.

     return true;
   }
 
   if ((match_type & FormField::MATCH_NAME) &&
-      MatchesPattern(field->name, pattern)) {
+      MatchesPattern(field->name, base::UTF16ToASCII(pattern))) {
     return true;
   }