autofill: switch autofill_regexes to RE2 library

components/autofill/core/browser/form_field.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/form_field.h"
 
 #include <stddef.h>
 #include <string>
 #include <utility>
 
@@ skipping 162 matching lines @@
   }
 
   return false;
 }
 
 // static
 bool FormField::Match(const AutofillField* field,
                       const base::string16& pattern,
                       int match_type) {
   if ((match_type & FormField::MATCH_LABEL) &&
-      MatchesPattern(field->label, pattern)) {
+      MatchesPattern(field->label, base::UTF16ToASCII(pattern))) {

[Evan Stade, 2015/11/25 19:33:01]

Yes, Ilya's suggestion is good :) This code is not :(

should be base::UTF16ToUTF8

[Ilya Sherman, 2015/11/25 22:18:14]

Actually, there should not be any conversion here at all.  Instead, you should
make the |pattern| above also be an std::string, since that's what the patterns
start out as.

That said, Evan's comment is also worth keeping in mind: UTF16 is typically not
safe to convert to ASCII; instead, you should convert it to UTF8.  Again, this
sort of conversion shouldn't be needed at all for this CL; but it's a good thing
to keep in mind for the future.

[tfarina, 2015/11/26 00:56:34]

Done. Though the changes are scaling.

     return true;
   }
 
   if ((match_type & FormField::MATCH_NAME) &&
-      MatchesPattern(field->name, pattern)) {
+      MatchesPattern(field->name, base::UTF16ToASCII(pattern))) {
     return true;
   }
 
   return false;
 }
 
 // static
 void FormField::ParseFormFieldsPass(ParseFunction parse,
                                     std::vector<AutofillField*>* fields,
                                     ServerFieldTypeMap* map) {
@@ skipping 37 matching lines @@
   if ((match_type & MATCH_PASSWORD) && type == "password")
     return true;
 
   if ((match_type & MATCH_NUMBER) && type == "number")
     return true;
 
   return false;
 }
 
 }  // namespace autofill