Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 145313004: Cleanup: Sanitize the order of includes under tests/ (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 11 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Cleanup: Sanitize the order of includes under tests/ Initially this was to make sure Test.h appeared after the Sk*.h includes. Patch generated by the following command line: $ ~/chromium/src/tools/sort-headers.py tests/*.cpp BUG=None TEST=tests R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=13177

Patch Set 1 #

Patch Set 2 : more two fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -146 lines) Patch
M tests/AAClipTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/AndroidPaintTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/AnnotationTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/AtomicTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BitSetTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BitmapCopyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BitmapGetColorTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/BlitRowTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CanvasStateTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ClampRangeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClipCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClipCubicTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ClipperTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ColorFilterTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/ColorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/DataRefTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/DequeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/DeviceLooperTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/DrawPathTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/DrawTextTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M tests/DynamicHashTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/EmptyPathTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ErrorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/FillPathTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/FitsInTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/FlatDataTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M tests/FlateTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/FontHostStreamTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M tests/FontHostTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/FontMgrTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/FontNamesTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/FrontBufferedStreamTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/GeometryTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GifTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GpuDrawPathTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrDrawTargetTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrMemoryPoolTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrUnitTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GradientTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageDecodingTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/InfRectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/JpegTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/LListTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/LayerDrawLooperTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M tests/MD5Test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/MathTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M tests/Matrix44Test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/MatrixTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/MemsetTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/MetaDataTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/MipMapTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/OSPathTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M tests/PackBitsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PaintTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ParsePathTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathCoverageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathMeasureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsCubicIntersectionTestData.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/PathOpsSimplifyFailTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/PathUtilsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PictureTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PictureUtilsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PipeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PixelRefTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/QuickRejectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RTreeTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/RandomTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ReadPixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Reader32Test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RefCntTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RefDictTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RegionTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/RoundRectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SHA1Test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ScalarTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SerializationTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M tests/ShaderImageFilterTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/ShaderOpacityTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/SkpSkGrTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/SortTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SrcOverTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/StreamTest.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/StringTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/StrokeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/TLSTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/TSetTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/TestSize.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/TileGridTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ToUnicode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/Typeface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/UnicodeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/UnitTestTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/UtilsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/WritePixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Writer32Test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/XfermodeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/skia_test.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
Hi Robert, could you review this to me? It is just a mechanical change. Thanks!
6 years, 11 months ago (2014-01-23 23:09:12 UTC) #1
robertphillips
lgtm
6 years, 11 months ago (2014-01-24 17:23:07 UTC) #2
tfarina
6 years, 11 months ago (2014-01-24 20:57:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r13177 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698