Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1453043005: simplify BlendTest.cpp (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

simplify BlendTest.cpp - streamline the testing down to just byte multiplies (that's always where the blend algorithms vary) - add another approximate multiply (x*y+255)>>8 - add another variant of the perfect multiply, ((x*y+128)*257)>>16 I've realized ((x*y+128)*257)>>16 might be just as fast in SSE/NEON as our current (x*y+x)>>8 approximation. Good to be testing it here. BUG=skia: Committed: https://skia.googlesource.com/skia/+/195fe08421f3a6c52ed621be96dbcc5393b41e69

Patch Set 1 #

Patch Set 2 : one more fine #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -251 lines) Patch
M tests/BlendTest.cpp View 1 1 chunk +52 lines, -251 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453043005/1
5 years, 1 month ago (2015-11-17 15:46:31 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453043005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453043005/20001
5 years, 1 month ago (2015-11-17 15:53:10 UTC) #6
mtklein_C
5 years, 1 month ago (2015-11-17 15:53:13 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 16:06:46 UTC) #10
reed1
lgtm
5 years, 1 month ago (2015-11-17 16:28:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453043005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453043005/20001
5 years, 1 month ago (2015-11-17 16:38:17 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 16:39:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/195fe08421f3a6c52ed621be96dbcc5393b41e69

Powered by Google App Engine
This is Rietveld 408576698