Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: context.py

Issue 145293006: Sort issues by their age in the commit queue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue
Patch Set: Addressing the comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pending_manager.py » ('j') | pending_manager.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: context.py
diff --git a/context.py b/context.py
index 60ae8280fe13049c72c2d47b315eca4221e5bbb5..bb12881f3089e4b9131be54027928812ec064ba5 100644
--- a/context.py
+++ b/context.py
@@ -5,12 +5,14 @@
class Context(object):
"""Class to hold context about a the current code review and checkout."""
- def __init__(self, rietveld, checkout, status, server_hooks_missing=False):
+ def __init__(self, rietveld, checkout, status, user,
+ server_hooks_missing=False):
"""
Args:
rietveld: Instance of rietveld.Rietveld.
checkout: Instance of checkout.SvnCheckout
status: Instance of async_push.AsyncPush.
+ user: The --user option to commit_queue
Paweł Hajdan Jr. 2014/01/29 02:38:24 Oh, since this also has Rietveld, does using just
Sergey Berezin 2014/01/29 17:41:43 Actually, in a dry run, Rietveld receives an empty
Paweł Hajdan Jr. 2014/01/29 18:49:47 Will it break in dry run? I think that unless it'd
server_hooks_missing: True if the project's SVN repository does not have
server-side hooks configured.
"""
@@ -18,3 +20,4 @@ class Context(object):
self.checkout = checkout
self.status = status
self.server_hooks_missing = server_hooks_missing
+ self.user = user
« no previous file with comments | « no previous file | pending_manager.py » ('j') | pending_manager.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698