Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: context.py

Issue 145293006: Sort issues by their age in the commit queue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue
Patch Set: Addressing the comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pending_manager.py » ('j') | pending_manager.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 class Context(object): 6 class Context(object):
7 """Class to hold context about a the current code review and checkout.""" 7 """Class to hold context about a the current code review and checkout."""
8 def __init__(self, rietveld, checkout, status, server_hooks_missing=False): 8 def __init__(self, rietveld, checkout, status, user,
9 server_hooks_missing=False):
9 """ 10 """
10 Args: 11 Args:
11 rietveld: Instance of rietveld.Rietveld. 12 rietveld: Instance of rietveld.Rietveld.
12 checkout: Instance of checkout.SvnCheckout 13 checkout: Instance of checkout.SvnCheckout
13 status: Instance of async_push.AsyncPush. 14 status: Instance of async_push.AsyncPush.
15 user: The --user option to commit_queue
Paweł Hajdan Jr. 2014/01/29 02:38:24 Oh, since this also has Rietveld, does using just
Sergey Berezin 2014/01/29 17:41:43 Actually, in a dry run, Rietveld receives an empty
Paweł Hajdan Jr. 2014/01/29 18:49:47 Will it break in dry run? I think that unless it'd
14 server_hooks_missing: True if the project's SVN repository does not have 16 server_hooks_missing: True if the project's SVN repository does not have
15 server-side hooks configured. 17 server-side hooks configured.
16 """ 18 """
17 self.rietveld = rietveld 19 self.rietveld = rietveld
18 self.checkout = checkout 20 self.checkout = checkout
19 self.status = status 21 self.status = status
20 self.server_hooks_missing = server_hooks_missing 22 self.server_hooks_missing = server_hooks_missing
23 self.user = user
OLDNEW
« no previous file with comments | « no previous file | pending_manager.py » ('j') | pending_manager.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698