blimp/net/stream_packet_reader.h - Issue 1452823011: Make PacketReader/PacketWriter interfaces async-only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/stream_packet_reader.h

Issue 1452823011: Make PacketReader/PacketWriter interfaces async-only. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address wez,haibin feedback Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/net/stream_packet_reader.h

diff --git a/blimp/net/stream_packet_reader.h b/blimp/net/stream_packet_reader.h

index 4468638dc409aa18cdd5096aa38fb2798d72b1cb..21a6dab89deec5b28d8a8659c39664d49a7c94d5 100644

--- a/blimp/net/stream_packet_reader.h

+++ b/blimp/net/stream_packet_reader.h

@@ -33,8 +33,8 @@ class BLIMP_NET_EXPORT StreamPacketReader : public PacketReader {

~StreamPacketReader() override;

// PacketReader implementation.

- int ReadPacket(const scoped_refptr<net::GrowableIOBuffer>& buf,

- const net::CompletionCallback& cb) override;

+ void ReadPacket(const scoped_refptr<net::GrowableIOBuffer>& buf,

+ const net::CompletionCallback& cb) override;

private:

enum class ReadState {

« blimp/net/packet_writer.h ('K') | « blimp/net/packet_writer.h ('k') | blimp/net/stream_packet_reader.cc » ('j') | no next file with comments »