Make PacketReader/PacketWriter interfaces async-only.

blimp/net/packet_writer.h

Index: blimp/net/packet_writer.h
diff --git a/blimp/net/packet_writer.h b/blimp/net/packet_writer.h
index e5dbb9a1d53d1543a02c478aad118f735f466702..d79e66d9b1e28503e40d23cdcf7c71633db939a3 100644
--- a/blimp/net/packet_writer.h
+++ b/blimp/net/packet_writer.h
@@ -21,14 +21,10 @@ class BLIMP_NET_EXPORT PacketWriter {
  public:
   virtual ~PacketWriter() {}
 
-  // Writes a packet of at least one byte in size to a connection.
-  //
-  // Returns net::OK or an error code if the operation executed successfully.
-  // Returns ERR_IO_PENDING if the operation will be executed asynchronously.
-  //     |cb| is later invoked with net::OK or an error code.
-  // An error code indicates that caller should stop using this writer.
-  virtual int WritePacket(scoped_refptr<net::DrainableIOBuffer> data,
-                          const net::CompletionCallback& callback) = 0;
+  // Invokes |cb| with net::OK if the write operation executed successfully.
+  // All other values indicate unrecoverable errors.

[Wez, 2015/11/30 21:33:24]

As for the reader, define the semantics wrt |cv| being called, or not being
called, after the writer has been deleted.

[Kevin M, 2015/12/01 01:50:27]

Done.

+  virtual void WritePacket(scoped_refptr<net::DrainableIOBuffer> data,
+                           const net::CompletionCallback& callback) = 0;
 };
 
 }  // namespace blimp