Chromium Code Reviews Chromium Code Reviews
Issue
145273019:
Clean up sign-in grammar (Closed)
DescriptionClean up sign-in grammar
---------------------------------
"Signin" is not a word.
"Sign into" doesn't make any more sense than "sign outof".
As a phrasal verb, it stands as a unit.
* "Bob signed in to Chromium to sync his settings."
* "Bob signed into Chromium, and it hurt. Next time he'll be more careful while
signing and walking in the chemistry lab."
Don't hurt Bob.
As a phrasal noun, "sign-in" should be hyphenated.
Follow these simple[1] rules for correct usage:
* "signin" is not a word
* "sign in to", not "sign into" (you wouldn't "sign outof" Chrome)
* as a noun or noun adjunct, "sign-in", not "sign in":
"Sign-in happens at the sign-in screen."
* as a participle + adverb:
* "signed-in" before a noun: "who is the signed-in cat?"
* "signed in" after a noun: "why is the cat signed in?"
Additionally, do not capitalize "in" or "out" in title case.
* "Sign in Again", not "Sign In Again"
[1] May not be simple.
---------------------------------
Secondly, we should say "sign in" instead of "log in" in most places.
---------------------------------
Sources:
* go/uxwordlist
* https://net.educause.edu/elements/attachments/educause/pdf/ch07_tab01.pdf
I'd like to have kuscher check my work. Including aruslan and derat for sign-off
because the changes are somewhat extensive.
BUG=315617
NOPRESUBMIT=true
R=kuscher@chromium.org, bulach@chromium.org, derat@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248881
Patch Set 1 #
Total comments: 4
Patch Set 2 : Rebase and comments addressed #Patch Set 3 : go away .gitmodules nobody likes you #Patch Set 4 : Move product-specific strings #Patch Set 5 : rebase #
Messages
Total messages: 28 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
