Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1875)

Issue 1452613002: KeyframeEffectTest: avoid keeping unnecessary Document reference. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

KeyframeEffectTest: avoid keeping unnecessary Document reference. Avoid introducing a Persistent<> to a Document for these unit tests, thereby not keeping an untraced heap reference with Oilpan. R=haraken BUG=553613 Committed: https://crrev.com/7cfa027ab9babe8b8a3857cb44c53d5f83652e32 Cr-Commit-Position: refs/heads/master@{#360029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp View 5 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
5 years, 1 month ago (2015-11-16 15:54:11 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-16 23:31:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1452613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1452613002/1
5 years, 1 month ago (2015-11-17 06:18:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 07:12:41 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 07:13:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cfa027ab9babe8b8a3857cb44c53d5f83652e32
Cr-Commit-Position: refs/heads/master@{#360029}

Powered by Google App Engine
This is Rietveld 408576698