KeyframeEffectTest: avoid keeping unnecessary Document reference.

third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/animation/KeyframeEffect.h"
 
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/UnionTypesCore.h"
 #include "bindings/core/v8/V8BindingForTesting.h"
 #include "bindings/core/v8/V8KeyframeEffectOptions.h"
 #include "core/animation/AnimationClock.h"
 #include "core/animation/AnimationEffectTiming.h"
 #include "core/animation/AnimationTestHelper.h"
 #include "core/animation/AnimationTimeline.h"
 #include "core/animation/KeyframeEffectModel.h"
 #include "core/animation/Timing.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/testing/DummyPageHolder.h"
 #include <gtest/gtest.h>
 #include <v8.h>
 
 namespace blink {
 
 class KeyframeEffectTest : public ::testing::Test {
 protected:
     KeyframeEffectTest()
         : pageHolder(DummyPageHolder::create())
-        , document(pageHolder->document())
-        , element(document.createElement("foo", ASSERT_NO_EXCEPTION))
     {
-        document.animationClock().resetTimeForTesting(document.timeline().zeroTime());
-        document.documentElement()->appendChild(element.get());
-        EXPECT_EQ(0, document.timeline().currentTime());
+        element = document().createElement("foo", ASSERT_NO_EXCEPTION);
+
+        document().animationClock().resetTimeForTesting(document().timeline().zeroTime());
+        document().documentElement()->appendChild(element.get());
+        EXPECT_EQ(0, document().timeline().currentTime());
     }
 
+    Document& document() const { return pageHolder->document(); }
+
     OwnPtr<DummyPageHolder> pageHolder;
-    Document& document;
     RefPtrWillBePersistent<Element> element;
     TrackExceptionState exceptionState;
 };
 
 class AnimationKeyframeEffectV8Test : public KeyframeEffectTest {
 protected:
     AnimationKeyframeEffectV8Test()
         : m_isolate(v8::Isolate::GetCurrent())
         , m_scope(m_isolate)
     {
@@ skipping 217 matching lines @@
 }
 
 TEST_F(KeyframeEffectTest, TimeToEffectChange)
 {
     Timing timing;
     timing.iterationDuration = 100;
     timing.startDelay = 100;
     timing.endDelay = 100;
     timing.fillMode = Timing::FillModeNone;
     KeyframeEffect* animation = KeyframeEffect::create(0, nullptr, timing);
-    Animation* player = document.timeline().play(animation);
+    Animation* player = document().timeline().play(animation);
     double inf = std::numeric_limits<double>::infinity();
 
     EXPECT_EQ(100, animation->timeToForwardsEffectChange());
     EXPECT_EQ(inf, animation->timeToReverseEffectChange());
 
     player->setCurrentTimeInternal(100);
     EXPECT_EQ(100, animation->timeToForwardsEffectChange());
     EXPECT_EQ(0, animation->timeToReverseEffectChange());
 
     player->setCurrentTimeInternal(199);
@@ skipping 12 matching lines @@
 
 TEST_F(KeyframeEffectTest, TimeToEffectChangeWithPlaybackRate)
 {
     Timing timing;
     timing.iterationDuration = 100;
     timing.startDelay = 100;
     timing.endDelay = 100;
     timing.playbackRate = 2;
     timing.fillMode = Timing::FillModeNone;
     KeyframeEffect* animation = KeyframeEffect::create(0, nullptr, timing);
-    Animation* player = document.timeline().play(animation);
+    Animation* player = document().timeline().play(animation);
     double inf = std::numeric_limits<double>::infinity();
 
     EXPECT_EQ(100, animation->timeToForwardsEffectChange());
     EXPECT_EQ(inf, animation->timeToReverseEffectChange());
 
     player->setCurrentTimeInternal(100);
     EXPECT_EQ(50, animation->timeToForwardsEffectChange());
     EXPECT_EQ(0, animation->timeToReverseEffectChange());
 
     player->setCurrentTimeInternal(149);
@@ skipping 12 matching lines @@
 
 TEST_F(KeyframeEffectTest, TimeToEffectChangeWithNegativePlaybackRate)
 {
     Timing timing;
     timing.iterationDuration = 100;
     timing.startDelay = 100;
     timing.endDelay = 100;
     timing.playbackRate = -2;
     timing.fillMode = Timing::FillModeNone;
     KeyframeEffect* animation = KeyframeEffect::create(0, nullptr, timing);
-    Animation* player = document.timeline().play(animation);
+    Animation* player = document().timeline().play(animation);
     double inf = std::numeric_limits<double>::infinity();
 
     EXPECT_EQ(100, animation->timeToForwardsEffectChange());
     EXPECT_EQ(inf, animation->timeToReverseEffectChange());
 
     player->setCurrentTimeInternal(100);
     EXPECT_EQ(50, animation->timeToForwardsEffectChange());
     EXPECT_EQ(0, animation->timeToReverseEffectChange());
 
     player->setCurrentTimeInternal(149);
@@ skipping 10 matching lines @@
 }
 
 TEST_F(KeyframeEffectTest, ElementDestructorClearsAnimationTarget)
 {
     // This test expects incorrect behaviour should be removed once Element
     // and KeyframeEffect are moved to Oilpan. See crbug.com/362404 for context.
     Timing timing;
     timing.iterationDuration = 5;
     KeyframeEffect* animation = KeyframeEffect::create(element.get(), nullptr, timing);
     EXPECT_EQ(element.get(), animation->target());
-    document.timeline().play(animation);
+    document().timeline().play(animation);
     pageHolder.clear();
     element.clear();
 }
 
 } // namespace blink