Subzero: Add a "make check-presubmit" target.

Makefile.standalone

Index: Makefile.standalone
diff --git a/Makefile.standalone b/Makefile.standalone
index f06ec157bda15388489b4a20587d0a383d4974c8..a157f59df89e733e7725229c5ec254383cbb64b8 100644
--- a/Makefile.standalone
+++ b/Makefile.standalone
@@ -417,16 +417,39 @@ ifeq ($(TARGET),arm32)
   SETUP=SetupGccArmOpt
   SPEC := -O2 --filetype=asm
 endif
-
+SPECFLAGS :=
+SPECBUILDONLY := false

[John, 2015/11/16 14:03:23]

\o/

[Jim Stichnoth, 2015/11/16 18:17:59]

Is there a complaint or suggestion here?

 %.spec2k: % $(OBJDIR)/pnacl-sz make_symlink runtime
-	./pydir/szbuild_spec2k.py -v --force --target=$(TARGETFLAG) $(SPEC) $<
-	( cd ../../../tests/spec2k; \
+	./pydir/szbuild_spec2k.py -v --force \
+          $(SPECFLAGS) --target=$(TARGETFLAG) $(SPEC) $<
+	$(SPECBUILDONLY) || ( cd ../../../tests/spec2k; \
 	 ./run_all.sh RunTimedBenchmarks $(SETUP) train $< )
 
 check-spec: $(ALLSPEC:=.spec2k)
 
 check: check-lit check-unit check-xtest
 
+NPROCS := $(shell grep processor /proc/cpuinfo | wc -l)
+
+check-presubmit:
+	make -f Makefile.standalone format
+	git diff --quiet
+	make -f Makefile.standalone -j$(NPROCS) \

[John, 2015/11/16 14:03:23]

Too aggressive? Maybe -j$(NPROCS - 5), or something?

[Jim Stichnoth, 2015/11/16 18:17:59]

FWIW, I always run -j32 on my z620 and -j4 on my laptop, with no problems
(insofar as building on one's laptop is "no problem").  Also, lit defaults to
using all processors.  Pretty sure that's common practice across the group.

That said, the right thing to do would be to "make -j32 check-presubmit" and get
the sub-make command to be passed the -j32.  But the interwebs seem to indicate
the /proc/cpuinfo trick as the "best" approach.  Any other ideas?

+          MINIMAL=1 check
+	make -f Makefile.standalone -j$(NPROCS) \
+          DEBUG=1 CHECK_X86_ASM=1 check-unit
+	make -f Makefile.standalone -j$(NPROCS) \
+          check check-spec
+	make -f Makefile.standalone -j$(NPROCS) \
+          SPECFLAGS='-Om1' SPECBUILDONLY=true check-spec
+	make -f Makefile.standalone -j$(NPROCS) \
+          SPECFLAGS='--sz=--phi-edge-split=0' check-spec
+	make -f Makefile.standalone -j$(NPROCS) \
+          TARGET=arm32 SPECBUILDONLY=true check-spec
+	make -f Makefile.standalone -j$(NPROCS) \
+          TARGET=arm32 SPECFLAGS='-Om1' SPECBUILDONLY=true check-spec
+	echo Success

[John, 2015/11/16 14:03:23]

Maybe run some light-weight benchmarks as a smoke test? mcf, gcc, and bzip (for
arm) would require an extra minute.

[Jim Stichnoth, 2015/11/16 18:17:59]

That's a good idea.

However, for now we have a problem since szbuild_spec2k.py creates binaries
named <component>.gcc.opt.arm32 but run_all.sh expects <component>.gcc.opt.arm .
 I'll tweak that in the script, but be aware of that when you go about building
and running on the ARM hardware.

+
 FORMAT_BLACKLIST =
 # Add one of the following lines for each source file to ignore.
 FORMAT_BLACKLIST += ! -name IceParseInstsTest.cpp