Subzero: Add a "make check-presubmit" target.

Makefile.standalone

 # The following variables will likely need to be modified, depending on where
 # and how you built LLVM & Clang. They can be overridden in a command-line
 # invocation of make, like:
 #
 #   make LLVM_SRC_PATH=<path> LIBCXX_INSTALL_PATH=<path> CLANG_PATH=<path> \
 #        PNACL_BIN_PATH=<path> ...
 #
 
 # LLVM_SRC_PATH is the path to the root of the checked out source code. This
 # directory should contain the configure script, the include/ and lib/
@@ skipping 399 matching lines @@
 ifeq ($(TARGET),x8632)
   TARGETFLAG=x8632
   SETUP=SetupGccX8632Opt
   SPEC := -O2 --filetype=obj
 endif
 ifeq ($(TARGET),arm32)
   TARGETFLAG=arm32
   SETUP=SetupGccArmOpt
   SPEC := -O2 --filetype=asm
 endif
-
+SPECFLAGS :=
+SPECBUILDONLY := false

[John, 2015/11/16 14:03:23]

\o/

[Jim Stichnoth, 2015/11/16 18:17:59]

Is there a complaint or suggestion here?

 %.spec2k: % $(OBJDIR)/pnacl-sz make_symlink runtime
-        ./pydir/szbuild_spec2k.py -v --force --target=$(TARGETFLAG) $(SPEC) $<
-        ( cd ../../../tests/spec2k; \
+        ./pydir/szbuild_spec2k.py -v --force \
+          $(SPECFLAGS) --target=$(TARGETFLAG) $(SPEC) $<
+        $(SPECBUILDONLY) || ( cd ../../../tests/spec2k; \
          ./run_all.sh RunTimedBenchmarks $(SETUP) train $< )
 
 check-spec: $(ALLSPEC:=.spec2k)
 
 check: check-lit check-unit check-xtest
 
+NPROCS := $(shell grep processor /proc/cpuinfo | wc -l)
+
+check-presubmit:
+        make -f Makefile.standalone format
+        git diff --quiet
+        make -f Makefile.standalone -j$(NPROCS) \

[John, 2015/11/16 14:03:23]

Too aggressive? Maybe -j$(NPROCS - 5), or something?

[Jim Stichnoth, 2015/11/16 18:17:59]

FWIW, I always run -j32 on my z620 and -j4 on my laptop, with no problems
(insofar as building on one's laptop is "no problem").  Also, lit defaults to
using all processors.  Pretty sure that's common practice across the group.

That said, the right thing to do would be to "make -j32 check-presubmit" and get
the sub-make command to be passed the -j32.  But the interwebs seem to indicate
the /proc/cpuinfo trick as the "best" approach.  Any other ideas?

+          MINIMAL=1 check
+        make -f Makefile.standalone -j$(NPROCS) \
+          DEBUG=1 CHECK_X86_ASM=1 check-unit
+        make -f Makefile.standalone -j$(NPROCS) \
+          check check-spec
+        make -f Makefile.standalone -j$(NPROCS) \
+          SPECFLAGS='-Om1' SPECBUILDONLY=true check-spec
+        make -f Makefile.standalone -j$(NPROCS) \
+          SPECFLAGS='--sz=--phi-edge-split=0' check-spec
+        make -f Makefile.standalone -j$(NPROCS) \
+          TARGET=arm32 SPECBUILDONLY=true check-spec
+        make -f Makefile.standalone -j$(NPROCS) \
+          TARGET=arm32 SPECFLAGS='-Om1' SPECBUILDONLY=true check-spec
+        echo Success

[John, 2015/11/16 14:03:23]

Maybe run some light-weight benchmarks as a smoke test? mcf, gcc, and bzip (for
arm) would require an extra minute.

[Jim Stichnoth, 2015/11/16 18:17:59]

That's a good idea.

However, for now we have a problem since szbuild_spec2k.py creates binaries
named <component>.gcc.opt.arm32 but run_all.sh expects <component>.gcc.opt.arm .
 I'll tweak that in the script, but be aware of that when you go about building
and running on the ARM hardware.

+
 FORMAT_BLACKLIST =
 # Add one of the following lines for each source file to ignore.
 FORMAT_BLACKLIST += ! -name IceParseInstsTest.cpp
 FORMAT_BLACKLIST += ! -name IceParseTypesTest.cpp
 FORMAT_BLACKLIST += ! -name assembler_arm.h
 FORMAT_BLACKLIST += ! -name assembler_arm.cc
 format:
         $(CLANG_FORMAT_PATH)/clang-format -style=LLVM -i \
           `find . -regex '.*\.\(c\|h\|cpp\)' $(FORMAT_BLACKLIST)`
 
@@ skipping 10 matching lines @@
 
 docs:
         doxygen Doxyfile
         @echo See file://`pwd`/docs/html/index.html
 
 clean:
         rm -rf pnacl-sz *.o $(OBJDIR) $(SB_OBJDIR) build/pnacl-sz.bloat.json
 
 clean-all: clean
         rm -rf build/ docs/