Issue 1452373004: Merge to XFA: Add Dr. Memory tool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1452373004: Merge to XFA: Add Dr. Memory tool (Closed)

Created:
5 years, 1 month ago by zhaoqin1

Modified:
5 years, 1 month ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Add Dr. Memory tool This CL adds DrMemory-Windows-sfx.exe into tools/drmemory. It also adds a set of scripts from chromium/src/tools/valgrind for running Dr. Memory. Now we can run pdfium tests with Dr. Memory: $ .\tools\drmemory\scripts\pdfium_tests.bat -b out\Debug -t pdfium_unittests More update on scripts is required, but this should be a good start. Changes from chromium/src/tools/valgrind - rename chrome_tests.py to pdfium_tests.py - update pdfium_tests.bat - remove chrome tests in pdfium_tests.py - remove memcheck code in valgrind_test.py R=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1452293002 . (cherry picked from commit 4dcf313c46c176e5afa1328f5f07fce4e614366d) Committed: https://pdfium.googlesource.com/pdfium/+/2ef59d1ec8dbb9d3d221309f04c71e2a562e771c

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1784 lines, -0 lines)			Patch
A	tools/drmemory/DrMemory-Windows-sfx.exe	View	Binary file		0 comments	Download
A	tools/drmemory/scripts/common.py	View	1 chunk	+252 lines, -0 lines	0 comments	Download
A	tools/drmemory/scripts/drmemory_analyze.py	View	1 chunk	+202 lines, -0 lines	0 comments	Download
A	tools/drmemory/scripts/logging_utils.py	View	1 chunk	+82 lines, -0 lines	0 comments	Download
A	tools/drmemory/scripts/path_utils.py	View	1 chunk	+84 lines, -0 lines	0 comments	Download
A	tools/drmemory/scripts/pdfium_tests.bat	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A	tools/drmemory/scripts/pdfium_tests.py	View	1 chunk	+370 lines, -0 lines	0 comments	Download
A	tools/drmemory/scripts/valgrind_test.py	View	1 chunk	+770 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zhaoqin1

Committed patchset #1 (id:1) manually as 2ef59d1ec8dbb9d3d221309f04c71e2a562e771c (presubmit successful).

5 years, 1 month ago (2015-11-18 22:21:53 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages