Add Dr. Memory tool

Add Dr. Memory tool

This CL adds DrMemory-Windows-sfx.exe into tools/drmemory.
It also adds a set of scripts from chromium/src/tools/valgrind for
running Dr. Memory.  Now we can run pdfium tests with Dr. Memory:
$ .\tools\drmemory\scripts\pdfium_tests.bat -b out\Debug -t pdfium_unittests

More update on scripts is required, but this should be a good start.

Changes from chromium/src/tools/valgrind
- rename chrome_tests.py to pdfium_tests.py
- update pdfium_tests.bat
- remove chrome tests in pdfium_tests.py
- remove memcheck code in valgrind_test.py

R=thestig@chromium.org
BUG=pdfium:238
Committed: https://pdfium.googlesource.com/pdfium/+/4dcf313c46c176e5afa1328f5f07fce4e614366d

[Lei Zhang, 2015-11-17 20:29:56]

This is also uploaded from your chromium.org account. :)

[zhaoqin1, 2015-11-17 20:50:15]

On 2015/11/17 20:29:56, Lei Zhang wrote:
> This is also uploaded from your http://chromium.org account. :)

hmm, what's wrong with my system. let me check.

[zhaoqin, 2015-11-17 22:00:59]

On 2015/11/17 20:50:15, zhaoqin1 wrote:
> On 2015/11/17 20:29:56, Lei Zhang wrote:
> > This is also uploaded from your http://chromium.org account. :)
> 
> hmm, what's wrong with my system. let me check.

Maybe I always use chromium account for review.
https://codereview.chromium.org/1410333007
was using that, but commit as google account.

Do not want to spend too much time on it, let's just see if it gonna work.

[Lei Zhang, 2015-11-17 23:07:23]

I'll just use this one for review.

Most of the files are just copied over from Chromium as-is, right?

https://codereview.chromium.org/1452293002/diff/20001/tools/drmemory/scripts/...
File tools/drmemory/scripts/pdfium_tests.py (right):

https://codereview.chromium.org/1452293002/diff/20001/tools/drmemory/scripts/...
tools/drmemory/scripts/pdfium_tests.py:528: def TestLayoutChunk(self, chunk_num,
chunk_size):
Can you clean up this file a bit? There's a lot of cruft all over, but these
really stick out.

[zhaoqin, 2015-11-17 23:27:04]

On 2015/11/17 23:07:23, Lei Zhang wrote:
> I'll just use this one for review.
> 
> Most of the files are just copied over from Chromium as-is, right?
> 
Yes,
- rename chrome_tests.py to pdfium_tests.py
- update pdfium_tests.bat
- remove memcheck in valgrind_test.py

>
https://codereview.chromium.org/1452293002/diff/20001/tools/drmemory/scripts/...
> File tools/drmemory/scripts/pdfium_tests.py (right):
> 
>
https://codereview.chromium.org/1452293002/diff/20001/tools/drmemory/scripts/...
> tools/drmemory/scripts/pdfium_tests.py:528: def TestLayoutChunk(self,
chunk_num,
> chunk_size):
> Can you clean up this file a bit? There's a lot of cruft all over, but these
> really stick out.

done

[zhaoqin, 2015-11-17 23:28:10]

Description was changed from

==========
Add Dr. Memory tool

This CL adds DrMemory-Windows-sfx.exe into tools/drmemory.
It also adds a set of scripts from chromium/src/tools/valgrind for
running Dr. Memory.  Now we can run pdfium tests with Dr. Memory:
$ .\tools\drmemory\scripts\pdfium_tests.bat -b out\Debug -t pdfium_unittests

More update on scripts is required, but this should be a good start.

R=thestig@chromium.org
BUG=pdfium:238
==========

to

==========
Add Dr. Memory tool

This CL adds DrMemory-Windows-sfx.exe into tools/drmemory.
It also adds a set of scripts from chromium/src/tools/valgrind for
running Dr. Memory.  Now we can run pdfium tests with Dr. Memory:
$ .\tools\drmemory\scripts\pdfium_tests.bat -b out\Debug -t pdfium_unittests

More update on scripts is required, but this should be a good start.

Changes from chromium/src/tools/valgrind
- rename chrome_tests.py to pdfium_tests.py
- update pdfium_tests.bat
- remove chrome tests in pdfium_tests.py
- remove memcheck code in valgrind_test.py

R=thestig@chromium.org
BUG=pdfium:238
==========

[Lei Zhang, 2015-11-17 23:33:05]

lgtm with some more cruft removed.

https://codereview.chromium.org/1452293002/diff/40001/tools/drmemory/scripts/...
File tools/drmemory/scripts/pdfium_tests.py (right):

https://codereview.chromium.org/1452293002/diff/40001/tools/drmemory/scripts/...
tools/drmemory/scripts/pdfium_tests.py:10: import multiprocessing
no longer used

https://codereview.chromium.org/1452293002/diff/40001/tools/drmemory/scripts/...
tools/drmemory/scripts/pdfium_tests.py:13: import stat
no longer used

https://codereview.chromium.org/1452293002/diff/40001/tools/drmemory/scripts/...
tools/drmemory/scripts/pdfium_tests.py:36: SLOW_TOOLS = ["memcheck", "drmemory"]
Remove memcheck reference.

https://codereview.chromium.org/1452293002/diff/40001/tools/drmemory/scripts/...
tools/drmemory/scripts/pdfium_tests.py:292: # Recognise the original
abbreviations as well as full executable names.
Comment not relevant here.

https://codereview.chromium.org/1452293002/diff/40001/tools/drmemory/scripts/...
tools/drmemory/scripts/pdfium_tests.py:312: parser.add_option("--baseline",
action="store_true", default=False,
Not used

[zhaoqin, 2015-11-18 16:26:36]

zhaoqin@google.com changed reviewers:
+ zhaoqin@google.com

[zhaoqin, 2015-11-18 16:26:36]

Thanks for review.

There are still many more to be removed/updated.
It might be better to first copy and then remove them after the first commit so
we have a history of changes recorded.
So more updates on the script is coming :).

https://codereview.chromium.org/1452293002/diff/40001/tools/drmemory/scripts/...
File tools/drmemory/scripts/pdfium_tests.py (right):

https://codereview.chromium.org/1452293002/diff/40001/tools/drmemory/scripts/...
tools/drmemory/scripts/pdfium_tests.py:10: import multiprocessing
On 2015/11/17 23:33:04, Lei Zhang wrote:
> no longer used

Done.

https://codereview.chromium.org/1452293002/diff/40001/tools/drmemory/scripts/...
tools/drmemory/scripts/pdfium_tests.py:13: import stat
On 2015/11/17 23:33:04, Lei Zhang wrote:
> no longer used

Done.

https://codereview.chromium.org/1452293002/diff/40001/tools/drmemory/scripts/...
tools/drmemory/scripts/pdfium_tests.py:36: SLOW_TOOLS = ["memcheck", "drmemory"]
On 2015/11/17 23:33:04, Lei Zhang wrote:
> Remove memcheck reference.

Done.

https://codereview.chromium.org/1452293002/diff/40001/tools/drmemory/scripts/...
tools/drmemory/scripts/pdfium_tests.py:292: # Recognise the original
abbreviations as well as full executable names.
On 2015/11/17 23:33:04, Lei Zhang wrote:
> Comment not relevant here.

Done.

https://codereview.chromium.org/1452293002/diff/40001/tools/drmemory/scripts/...
tools/drmemory/scripts/pdfium_tests.py:312: parser.add_option("--baseline",
action="store_true", default=False,
On 2015/11/17 23:33:04, Lei Zhang wrote:
> Not used

Done.

[zhaoqin1, 2015-11-18 17:08:28]

Committed patchset #4 (id:60001) manually as
4dcf313c46c176e5afa1328f5f07fce4e614366d (presubmit successful).