Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: src/DartARM32/assembler_arm.h

Issue 1452293003: Add BL (immediate) and BLX (register) to ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | src/IceAssemblerARM32.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/DartARM32/assembler_arm.h
diff --git a/src/DartARM32/assembler_arm.h b/src/DartARM32/assembler_arm.h
index c85109e3457d52aebb86713cd5db40bc3d8b6d9b..fd4c000372da618024faffbb62cc4208777a8cef 100644
--- a/src/DartARM32/assembler_arm.h
+++ b/src/DartARM32/assembler_arm.h
@@ -28,7 +28,7 @@ class RuntimeEntry;
class StubEntry;
#if 0
-// Moved to: ARM32::AssemblerARM32 as needed
+// Moved to ARM32::AssemblerARM32 as needed
// Instruction encoding bits.
enum {
H = 1 << 5, // halfword (or byte)
@@ -596,7 +596,7 @@ class Assembler : public ValueObject {
void nop(Condition cond = AL);
#if 0
- // Moved to: ARM32::AssemblerARM32::bkpt()
+ // Moved to ARM32::AssemblerARM32::bkpt()
// Note that gdb sets breakpoints using the undefined instruction 0xe7f001f0.
void bkpt(uint16_t imm16);
@@ -724,13 +724,16 @@ class Assembler : public ValueObject {
void vzipqw(QRegister qd, QRegister qm);
// Branch instructions.
+#if 0
+ // Moved to ARM32::AssemblerARM32::b();
void b(Label* label, Condition cond = AL);
+ // Moved to ARM32::AssemblerARM32::bl()
void bl(Label* label, Condition cond = AL);
-#if 0
- // Moved to: ARM32::AssemblerARM32::bx()
+ // Moved to ARM32::AssemblerARM32::bx()
void bx(Register rm, Condition cond = AL);
-#endif
+ // Moved to ARM32::AssemblerARM32::blx()
void blx(Register rm, Condition cond = AL);
+#endif
void Branch(const StubEntry& stub_entry,
Patchability patchable = kNotPatchable,
@@ -1264,8 +1267,9 @@ class Assembler : public ValueObject {
DRegister dd, DRegister dn, DRegister dm);
void EmitFarBranch(Condition cond, int32_t offset, bool link);
- void EmitBranch(Condition cond, Label* label, bool link);
#if 0
+ // Moved to ARM32::AssemblerARM32::emitBranch()
+ void EmitBranch(Condition cond, Label* label, bool link);
// Moved to ARM32::AssemblerARM32::encodeBranchoffset().
int32_t EncodeBranchOffset(int32_t offset, int32_t inst);
// Moved to ARM32::AssemberARM32::decodeBranchOffset().
« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | src/IceAssemblerARM32.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698