Fix i#263: memory leaks from RenderPdf

Fix pdfium-i#236: memory leaks from RenderPdf

- add FPDFAvail_Destroy(pdf_avail) on the early return path in RenderPdf

R=thestig@chromium.org
BUG=pdfium:236
Committed: https://pdfium.googlesource.com/pdfium/+/0223be82e0afcfee7c501ad2754230353bff79ff

[Lei Zhang, 2015-10-20 21:58:37]

It's actually 236. Please write it as BUG=pdfium:236. Otherwise it defaults to
Chromium bug 236.

[Lei Zhang, 2015-10-20 21:59:52]

The code itself looks fine.

Please remember that you'll need to commit via "git cl land" so the commit
message needs to be correct in git locally as well.

[Lei Zhang, 2015-10-20 22:00:24]

On 2015/10/20 21:59:52, Lei Zhang wrote:
> The code itself looks fine.
> 
> Please remember that you'll need to commit via "git cl land" so the commit
> message needs to be correct in git locally as well.

At least I think that's how it works.

[zhaoqin1, 2015-10-20 22:02:45]

On 2015/10/20 22:00:24, Lei Zhang wrote:
> On 2015/10/20 21:59:52, Lei Zhang wrote:
> > The code itself looks fine.
> > 
> > Please remember that you'll need to commit via "git cl land" so the commit
> > message needs to be correct in git locally as well.
> 
> At least I think that's how it works.

commit 0c55766e4ead5c86b7cfd49f275d8057721e3319
Author: Qin Zhao <zhaoqin@google.com>
Date:   Tue Oct 20 16:38:59 2015 -0400

    Fix pdfium-i#236: memory leaks from RenderPdf

    - add FPDFAvail_Destroy(pdf_avail) on the early return path in RenderPdf

    R=thestig@chromium.org
    BUG=pdfium:236

[zhaoqin1, 2015-10-20 22:03:29]

Description was changed from

==========
Fix i#263: memory leaks from RenderPdf

- add FPDFAvail_Destroy(pdf_avail) on the early return path in RenderPdf

R=thestig@chromium.org
BUG=263
==========

to

==========
Fix pdfium-i#236: memory leaks from RenderPdf

- add FPDFAvail_Destroy(pdf_avail) on the early return path in RenderPdf

R=thestig@chromium.org
BUG=pdfium:236
==========

[zhaoqin1, 2015-10-20 22:03:54]

On 2015/10/20 22:02:45, zhaoqin1 wrote:
> On 2015/10/20 22:00:24, Lei Zhang wrote:
> > On 2015/10/20 21:59:52, Lei Zhang wrote:
> > > The code itself looks fine.
> > > 
> > > Please remember that you'll need to commit via "git cl land" so the commit
> > > message needs to be correct in git locally as well.
> > 
> > At least I think that's how it works.
> 
> commit 0c55766e4ead5c86b7cfd49f275d8057721e3319
> Author: Qin Zhao <mailto:zhaoqin@google.com>
> Date:   Tue Oct 20 16:38:59 2015 -0400
> 
>     Fix pdfium-i#236: memory leaks from RenderPdf
> 
>     - add FPDFAvail_Destroy(pdf_avail) on the early return path in RenderPdf
> 
>     mailto:R=thestig@chromium.org
>     BUG=pdfium:236

updated both locally and in review.

[Lei Zhang, 2015-10-20 22:05:21]

lgtm

[zhaoqin1, 2015-10-20 22:20:17]

Committed patchset #2 (id:20001) manually as
0223be82e0afcfee7c501ad2754230353bff79ff (presubmit successful).

[dsinclair, 2015-10-21 13:00:31]

On 2015/10/20 21:59:52, Lei Zhang wrote:
> The code itself looks fine.
> 
> Please remember that you'll need to commit via "git cl land" so the commit
> message needs to be correct in git locally as well.


git cl land uses the description from rietveld as it squashes all of the local
commits together. The local commit messages don't matter.