third_party/WebKit/Source/core/paint/PaintLayer.cpp - Issue 1452233002: Fix the reference box computation for CSS filter effects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1452233002: Fix the reference box computation for CSS filter effects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switch to using physicalBoundingBoxIncludingReflectionAndStackingChildren; add nullptr check Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

index ded24777fc93352efa5270495cbf6fd8340df234..aa9161f91f7aa97cda0308791155a7b6f9337080 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

@@ -2078,7 +2078,7 @@ static inline LayoutRect flippedLogicalBoundingBox(LayoutRect boundingBox, Layou

LayoutRect result = boundingBox;

if (layoutObjects->isBox())

toLayoutBox(layoutObjects)->flipForWritingMode(result);

- else

+ else if (layoutObjects->containingBlock())

layoutObjects->containingBlock()->flipForWritingMode(result);

return result;

}

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp ('k') | no next file » | no next file with comments »