Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1452233002: Fix the reference box computation for CSS filter effects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch to using physicalBoundingBoxIncludingReflectionAndStackingChildren; add nullptr check Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 2060 matching lines...) Expand 10 before | Expand all | Expand 10 after
2071 LayoutRect PaintLayer::logicalBoundingBox() const 2071 LayoutRect PaintLayer::logicalBoundingBox() const
2072 { 2072 {
2073 return layoutObject()->visualOverflowRect(); 2073 return layoutObject()->visualOverflowRect();
2074 } 2074 }
2075 2075
2076 static inline LayoutRect flippedLogicalBoundingBox(LayoutRect boundingBox, Layou tObject* layoutObjects) 2076 static inline LayoutRect flippedLogicalBoundingBox(LayoutRect boundingBox, Layou tObject* layoutObjects)
2077 { 2077 {
2078 LayoutRect result = boundingBox; 2078 LayoutRect result = boundingBox;
2079 if (layoutObjects->isBox()) 2079 if (layoutObjects->isBox())
2080 toLayoutBox(layoutObjects)->flipForWritingMode(result); 2080 toLayoutBox(layoutObjects)->flipForWritingMode(result);
2081 else 2081 else if (layoutObjects->containingBlock())
2082 layoutObjects->containingBlock()->flipForWritingMode(result); 2082 layoutObjects->containingBlock()->flipForWritingMode(result);
2083 return result; 2083 return result;
2084 } 2084 }
2085 2085
2086 LayoutRect PaintLayer::physicalBoundingBox(const PaintLayer* ancestorLayer) cons t 2086 LayoutRect PaintLayer::physicalBoundingBox(const PaintLayer* ancestorLayer) cons t
2087 { 2087 {
2088 LayoutPoint offsetFromRoot; 2088 LayoutPoint offsetFromRoot;
2089 convertToLayerCoords(ancestorLayer, offsetFromRoot); 2089 convertToLayerCoords(ancestorLayer, offsetFromRoot);
2090 return physicalBoundingBox(offsetFromRoot); 2090 return physicalBoundingBox(offsetFromRoot);
2091 } 2091 }
(...skipping 646 matching lines...) Expand 10 before | Expand all | Expand 10 after
2738 2738
2739 void showLayerTree(const blink::LayoutObject* layoutObject) 2739 void showLayerTree(const blink::LayoutObject* layoutObject)
2740 { 2740 {
2741 if (!layoutObject) { 2741 if (!layoutObject) {
2742 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n"); 2742 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n");
2743 return; 2743 return;
2744 } 2744 }
2745 showLayerTree(layoutObject->enclosingLayer()); 2745 showLayerTree(layoutObject->enclosingLayer());
2746 } 2746 }
2747 #endif 2747 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698