Parametric SkPath oval/rect/rrect starting point

Parametric SkPath oval/rect/rrect starting point

Extend the SkPath API to allow specifying the contour starting point.

This will allow removing the explicit cubic code from Blink/Path.

BUG=chromium:315277
R=reed@google.com,caryclark@google.com

Committed: https://skia.googlesource.com/skia/+/c08d53ee175e190254d8fd6659d9ad051ac0ba46

[f(malita), 2015-11-17 14:56:28]

Still planning to add a GM + unit tests for the new behavior, but there should
be no numerical difference for existing/legacy clients (no DM diffs observable
with local runs).

[reed1, 2015-11-17 15:02:51]

https://codereview.chromium.org/1452203002/diff/1/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/1452203002/diff/1/include/core/SkPath.h#newco...
include/core/SkPath.h:604: *  @param dir  The direction to wind the oval's
contour.
Should we document here where our starting point is?

https://codereview.chromium.org/1452203002/diff/1/include/core/SkPath.h#newco...
include/core/SkPath.h:614: *               as an index of the ellipse vertices
in 90/0/270/180deg order:
Might add that the 0->1->2->3 ordering is in CW direction (to help reinforce how
we use Direction)

https://codereview.chromium.org/1452203002/diff/1/include/core/SkPath.h#newco...
include/core/SkPath.h:677: void addRRect(const SkRRect& rrect, Direction dir =
kCW_Direction);
Document where our starting point is?

[f(malita), 2015-11-17 15:31:46]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 15:31:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1452203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1452203002/20001

[f(malita), 2015-11-17 15:35:16]

https://codereview.chromium.org/1452203002/diff/1/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/1452203002/diff/1/include/core/SkPath.h#newco...
include/core/SkPath.h:604: *  @param dir  The direction to wind the oval's
contour.
On 2015/11/17 15:02:51, reed1 wrote:
> Should we document here where our starting point is?

Done.

https://codereview.chromium.org/1452203002/diff/1/include/core/SkPath.h#newco...
include/core/SkPath.h:614: *               as an index of the ellipse vertices
in 90/0/270/180deg order:
On 2015/11/17 15:02:51, reed1 wrote:
> Might add that the 0->1->2->3 ordering is in CW direction (to help reinforce
how
> we use Direction)

Done.

https://codereview.chromium.org/1452203002/diff/1/include/core/SkPath.h#newco...
include/core/SkPath.h:677: void addRRect(const SkRRect& rrect, Direction dir =
kCW_Direction);
On 2015/11/17 15:02:51, reed1 wrote:
> Document where our starting point is?

Done.

[f(malita), 2015-11-17 15:35:25]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 15:35:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1452203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1452203002/40001

[caryclark, 2015-11-17 15:36:15]

lgtm

[commit-bot: I haz the power, 2015-11-17 15:48:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 15:48:12]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-11-17 16:26:53]

lgtm

[f(malita), 2015-11-17 17:52:43]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2015-11-17 17:52:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1452203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1452203002/40001

[commit-bot: I haz the power, 2015-11-17 17:53:32]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c08d53ee175e190254d8fd6659d9ad051ac0ba46