Parametric SkPath oval/rect/rrect starting point

include/core/SkPath.h

 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkPath_DEFINED
 #define SkPath_DEFINED
 
@@ skipping 550 matching lines @@
 
     /**
      *  Add a closed rectangle contour to the path
      *  @param rect The rectangle to add as a closed contour to the path
      *  @param dir  The direction to wind the rectangle's contour.
      */
     void addRect(const SkRect& rect, Direction dir = kCW_Direction);
 
     /**
      *  Add a closed rectangle contour to the path
+     *  @param rect  The rectangle to add as a closed contour to the path
+     *  @param dir   The direction to wind the rectangle's contour.
+     *  @param start Starting point for the contour (initial moveTo), expressed as
+     *               a corner index, starting in the upper-left position, clock-wise:
+     *
+     *  0         1
+     *   *-------*
+     *   |       |
+     *   *-------*
+     *  3         2
+     */
+    void addRect(const SkRect& rect, Direction dir, unsigned start);
+
+    /**
+     *  Add a closed rectangle contour to the path
      *
      *  @param left     The left side of a rectangle to add as a closed contour
      *                  to the path
      *  @param top      The top of a rectangle to add as a closed contour to the
      *                  path
      *  @param right    The right side of a rectangle to add as a closed contour
      *                  to the path
      *  @param bottom   The bottom of a rectangle to add as a closed contour to
      *                  the path
      *  @param dir  The direction to wind the rectangle's contour.
      */
     void addRect(SkScalar left, SkScalar top, SkScalar right, SkScalar bottom,
                  Direction dir = kCW_Direction);
 
     /**
      *  Add a closed oval contour to the path
      *
      *  @param oval The bounding oval to add as a closed contour to the path
      *  @param dir  The direction to wind the oval's contour.

[reed1, 2015/11/17 15:02:51]

Should we document here where our starting point is?

[f(malita), 2015/11/17 15:35:15]

Done.

      */
     void addOval(const SkRect& oval, Direction dir = kCW_Direction);
 
     /**
+     *  Add a closed oval contour to the path
+     *
+     *  @param oval  The bounding oval to add as a closed contour to the path
+     *  @param dir   The direction to wind the oval's contour.
+     *  @param start Starting point for the contour (initial moveTo), expressed
+     *               as an index of the ellipse vertices in 90/0/270/180deg order:

[reed1, 2015/11/17 15:02:51]

Might add that the 0->1->2->3 ordering is in CW direction (to help reinforce how
we use Direction)

[f(malita), 2015/11/17 15:35:15]

Done.

+     *
+     *        0
+     *       -*-
+     *     |     |
+     *   3 *     * 1
+     *     |     |
+     *       -*-
+     *        2
+     */
+    void addOval(const SkRect& oval, Direction dir, unsigned start);
+
+    /**
      *  Add a closed circle contour to the path
      *
      *  @param x        The x-coordinate of the center of a circle to add as a
      *                  closed contour to the path
      *  @param y        The y-coordinate of the center of a circle to add as a
      *                  closed contour to the path
      *  @param radius   The radius of a circle to add as a closed contour to the
      *                  path
      *  @param dir  The direction to wind the circle's contour.
      */
@@ skipping 30 matching lines @@
      *       sqaure corner and oversized radii are proportionally scaled down).
      */
     void addRoundRect(const SkRect& rect, const SkScalar radii[],
                       Direction dir = kCW_Direction);
 
     /**
      *  Add an SkRRect contour to the path
      *  @param rrect The rounded rect to add as a closed contour
      *  @param dir   The winding direction for the new contour.
      */
     void addRRect(const SkRRect& rrect, Direction dir = kCW_Direction);

[reed1, 2015/11/17 15:02:51]

Document where our starting point is?

[f(malita), 2015/11/17 15:35:15]

Done.

 
     /**
+     *  Add an SkRRect contour to the path
+     *  @param rrect The rounded rect to add as a closed contour
+     *  @param dir   The winding direction for the new contour.
+     *  @param start Starting point for the contour (initial moveTo), expressed as
+     *               an index of the radii minor/major points, ordered clock-wise:
+     *
+     *      0    1
+     *      *----*
+     *   7 *      * 2
+     *     |      |
+     *   6 *      * 3
+     *      *----*
+     *      5    4
+     */
+    void addRRect(const SkRRect& rrect, Direction dir, unsigned startIndex);
+
+    /**
      *  Add a new contour made of just lines. This is just a fast version of
      *  the following:
      *      this->moveTo(pts[0]);
      *      for (int i = 1; i < count; ++i) {
      *          this->lineTo(pts[i]);
      *      }
      *      if (close) {
      *          this->close();
      *      }
      */
@@ skipping 344 matching lines @@
     void setPt(int index, SkScalar x, SkScalar y);
 
     friend class SkAutoPathBoundsUpdate;
     friend class SkAutoDisableOvalCheck;
     friend class SkAutoDisableDirectionCheck;
     friend class SkBench_AddPathTest; // perf test reversePathTo
     friend class PathTest_Private; // unit test reversePathTo
 };
 
 #endif