Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 14520011: Fix binding integrity check when constructor wrappers are used in place of the actual type wrappers… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8Float64Array.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com> 2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org> 4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
5 # Copyright (C) 2006 Apple Computer, Inc. 5 # Copyright (C) 2006 Apple Computer, Inc.
6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc. 6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 # Copyright (C) Research In Motion Limited 2010. All rights reserved. 8 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 # Copyright (C) 2012 Ericsson AB. All rights reserved. 10 # Copyright (C) 2012 Ericsson AB. All rights reserved.
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 649
650 v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> creation Context, v8::Isolate*); 650 v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> creation Context, v8::Isolate*);
651 END 651 END
652 } else { 652 } else {
653 AddToHeader(<<END); 653 AddToHeader(<<END);
654 654
655 inline v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> c reationContext, v8::Isolate* isolate) 655 inline v8::Handle<v8::Object> wrap(${nativeType}* impl, v8::Handle<v8::Object> c reationContext, v8::Isolate* isolate)
656 { 656 {
657 ASSERT(impl); 657 ASSERT(impl);
658 ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty()); 658 ASSERT(DOMDataStore::getWrapper(impl, isolate).IsEmpty());
659 if (ScriptWrappable::wrapperCanBeStoredInObject(impl)) {
660 const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObje ct(impl);
661 // Might be a XXXConstructor::info instead of an XXX::info. These will both have
662 // the same object de-ref functions, though, so use that as the basis of the check.
663 RELEASE_ASSERT(actualInfo->derefObjectFunction == ${v8InterfaceName}::in fo.derefObjectFunction);
664 }
659 return ${returningCreatedWrapperOpening}$createWrapperCall(impl, creationCon text, isolate)${returningCreatedWrapperClosing}; 665 return ${returningCreatedWrapperOpening}$createWrapperCall(impl, creationCon text, isolate)${returningCreatedWrapperClosing};
660 } 666 }
661 END 667 END
662 } 668 }
663 669
664 AddToHeader(<<END); 670 AddToHeader(<<END);
665 671
666 inline v8::Handle<v8::Value> toV8(${nativeType}* impl, v8::Handle<v8::Object> cr eationContext, v8::Isolate* isolate) 672 inline v8::Handle<v8::Value> toV8(${nativeType}* impl, v8::Handle<v8::Object> cr eationContext, v8::Isolate* isolate)
667 { 673 {
668 if (UNLIKELY(!impl)) 674 if (UNLIKELY(!impl))
(...skipping 4841 matching lines...) Expand 10 before | Expand all | Expand 10 after
5510 if ($currentInterface->extendedAttributes->{$extendedAttribute}) { 5516 if ($currentInterface->extendedAttributes->{$extendedAttribute}) {
5511 $found = 1; 5517 $found = 1;
5512 } 5518 }
5513 return 1 if $found; 5519 return 1 if $found;
5514 }, 0); 5520 }, 0);
5515 5521
5516 return $found; 5522 return $found;
5517 } 5523 }
5518 5524
5519 1; 5525 1;
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8Float64Array.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698