Rename chrome_views_delegate_aura to chrome_views_delegate_ash

Rename chrome_views_delegate_aura to chrome_views_delegate_ash

It looks like chrome_views_delegate_aura use ash_util.h, which only included
when ash=1. So rename the old file to chrome_views_delegate_ash

This is needed because Aura Android will set use_aura to
true but use_ash to false.

BUG=557285
Committed: https://crrev.com/a1838dc89b879f5099ead5323e091f915cb89e9d
Cr-Commit-Position: refs/heads/master@{#360430}

[bshe, 2015-11-17 19:02:15]

Description was changed from

==========
Rename to chrome_views_delegate_aura to chrome_views_delegate_ash

It looks like chrome_views_delegate_aura use ash_util.h, which only included
when ash=1. So rename the old file to chrome_views_delegate_ash

BUG=
==========

to

==========
Rename to chrome_views_delegate_aura to chrome_views_delegate_ash

It looks like chrome_views_delegate_aura use ash_util.h, which only included
when ash=1. So rename the old file to chrome_views_delegate_ash

BUG=557285
==========

[bshe, 2015-11-17 19:02:59]

Description was changed from

==========
Rename to chrome_views_delegate_aura to chrome_views_delegate_ash

It looks like chrome_views_delegate_aura use ash_util.h, which only included
when ash=1. So rename the old file to chrome_views_delegate_ash

BUG=557285
==========

to

==========
Rename to chrome_views_delegate_aura to chrome_views_delegate_ash

It looks like chrome_views_delegate_aura use ash_util.h, which only included
when ash=1. So rename the old file to chrome_views_delegate_ash

This is needed because Aura Android will set use_aura to
true but use_ash to false.

BUG=557285
==========

[bshe, 2015-11-17 19:05:15]

bshe@chromium.org changed reviewers:
+ mfomitchev@chromium.org, sky@chromium.org

[bshe, 2015-11-17 19:05:16]

Hi Mikhail an Scott.
Do you mind take a look at this CL?

[mfomitchev, 2015-11-17 23:35:46]

The change looks fine to me, but I don't understand how did this ever work for
non-Ash Aura platforms (Linux and non-Metro Windows)?

[bshe, 2015-11-18 14:30:26]

On 2015/11/17 23:35:46, mfomitchev wrote:
> The change looks fine to me, but I don't understand how did this ever work for
> non-Ash Aura platforms (Linux and non-Metro Windows)?

We wont build non-ash aura chrome to reduce the maintenance cost if I understand
correctly: https://code.google.com/p/chromium/issues/detail?id=300084
use_ash and use_aura seem to set to 1 in common.gypi:
https://code.google.com/p/chromium/codesearch/#chromium/src/build/common.gypi...
Unless we override it in our build config, we wont build non-ash chrome?

[mfomitchev, 2015-11-18 17:13:01]

On 2015/11/18 14:30:26, bshe wrote:
> On 2015/11/17 23:35:46, mfomitchev wrote:
> > The change looks fine to me, but I don't understand how did this ever work
for
> > non-Ash Aura platforms (Linux and non-Metro Windows)?
> 
> We wont build non-ash aura chrome to reduce the maintenance cost if I
understand
> correctly: https://code.google.com/p/chromium/issues/detail?id=300084
> use_ash and use_aura seem to set to 1 in common.gypi:
>
https://code.google.com/p/chromium/codesearch/#chromium/src/build/common.gypi...
> Unless we override it in our build config, we wont build non-ash chrome?

Ah, didn't know about this, thanks! LGTM, just please fix the title/description
(too many "to"s).

[bshe, 2015-11-18 17:13:57]

Description was changed from

==========
Rename to chrome_views_delegate_aura to chrome_views_delegate_ash

It looks like chrome_views_delegate_aura use ash_util.h, which only included
when ash=1. So rename the old file to chrome_views_delegate_ash

This is needed because Aura Android will set use_aura to
true but use_ash to false.

BUG=557285
==========

to

==========
Rename chrome_views_delegate_aura to chrome_views_delegate_ash

It looks like chrome_views_delegate_aura use ash_util.h, which only included
when ash=1. So rename the old file to chrome_views_delegate_ash

This is needed because Aura Android will set use_aura to
true but use_ash to false.

BUG=557285
==========

[bshe, 2015-11-18 17:14:57]

On 2015/11/18 17:13:01, mfomitchev wrote:
> On 2015/11/18 14:30:26, bshe wrote:
> > On 2015/11/17 23:35:46, mfomitchev wrote:
> > > The change looks fine to me, but I don't understand how did this ever work
> for
> > > non-Ash Aura platforms (Linux and non-Metro Windows)?
> > 
> > We wont build non-ash aura chrome to reduce the maintenance cost if I
> understand
> > correctly: https://code.google.com/p/chromium/issues/detail?id=300084
> > use_ash and use_aura seem to set to 1 in common.gypi:
> >
>
https://code.google.com/p/chromium/codesearch/#chromium/src/build/common.gypi...
> > Unless we override it in our build config, we wont build non-ash chrome?
> 
> Ah, didn't know about this, thanks! LGTM, just please fix the
title/description
> (too many "to"s).

done!

[sky, 2015-11-18 20:40:37]

LGTM

[bshe, 2015-11-18 21:33:56]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2015-11-18 21:35:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1451973002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1451973002/20001

[commit-bot: I haz the power, 2015-11-18 22:38:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-18 22:39:48]

Patchset 2 (id:??) landed as
https://crrev.com/a1838dc89b879f5099ead5323e091f915cb89e9d
Cr-Commit-Position: refs/heads/master@{#360430}