Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1451813002: [Sync] Some cleanup of SyncTestUtil. (Closed)

Created:
5 years, 1 month ago by maxbogue
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@nigori
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Some cleanup of SyncTestUtil. - Removes the Context argument from places it isn't needed. - Removes everything related to about://sync as there are now better ways to access sync state. - Have just TIMEOUT_MS and INTERVAL_MS. - Some other misc cleanups. BUG=556621 Committed: https://crrev.com/78b449d801f2b1155c0a6aa2175cdea5f0f77a93 Cr-Commit-Position: refs/heads/master@{#360586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -365 lines) Patch
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/AutofillTest.java View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java View 17 chunks +21 lines, -21 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/GmsCoreSyncListenerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 5 chunks +1 line, -71 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java View 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/sync/SyncTestUtil.java View 8 chunks +31 lines, -236 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
maxbogue
Hey Patrick, PTAL! This is at least a start for cleaning up SyncTestUtil.
5 years, 1 month ago (2015-11-18 17:02:55 UTC) #2
pval...(no longer on Chromium)
lgtm nice cleanup/improvements
5 years, 1 month ago (2015-11-18 22:47:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451813002/1
5 years, 1 month ago (2015-11-19 14:51:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 15:44:41 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 15:46:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78b449d801f2b1155c0a6aa2175cdea5f0f77a93
Cr-Commit-Position: refs/heads/master@{#360586}

Powered by Google App Engine
This is Rietveld 408576698