Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1451793002: Add RandomString() and its test, and use it everywhere it makes sense (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Add RandomString() and its test, and use it everywhere it makes sense This unifies several things that used a 16-character random string, and a few other users of random identifiers where it also made sense to use a 16-character random string. TEST=crashpad_util_test RandomString.RandomString R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4f09b58d1fbd4be3eb8cef2d1682c37854f90df6

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix tpyo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -54 lines) Patch
M test/mac/mach_multiprocess.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M test/scoped_temp_dir_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M util/mac/service_management_test.mm View 2 chunks +2 lines, -5 lines 0 comments Download
M util/mach/child_port_handshake.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M util/mach/mach_extensions_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
A + util/misc/random_string.h View 1 chunk +10 lines, -7 lines 0 comments Download
A + util/misc/random_string.cc View 1 chunk +10 lines, -12 lines 0 comments Download
A util/misc/random_string_test.cc View 1 1 chunk +71 lines, -0 lines 0 comments Download
M util/net/http_transport_test.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M util/net/http_transport_test_server.py View 2 chunks +3 lines, -3 lines 0 comments Download
M util/util.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M util/util_test.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M util/win/exception_handler_server.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M util/win/process_info_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 1 month ago (2015-11-16 17:32:12 UTC) #2
scottmg
Good stuff, lgtm. https://codereview.chromium.org/1451793002/diff/1/util/misc/random_string_test.cc File util/misc/random_string_test.cc (right): https://codereview.chromium.org/1451793002/diff/1/util/misc/random_string_test.cc#newcode60 util/misc/random_string_test.cc:60: // extremely unlikley, for a character ...
5 years, 1 month ago (2015-11-16 18:24:32 UTC) #3
Mark Mentovai
5 years, 1 month ago (2015-11-16 18:39:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4f09b58d1fbd4be3eb8cef2d1682c37854f90df6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698