Add RandomString() and its test, and use it everywhere it makes sense

util/net/http_transport_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/net/http_transport.h"
 
 #include <stdint.h>
 #include <stdlib.h>
 #include <string.h>
 
 #include <vector>
 
 #include "base/files/file_path.h"
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/rand_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "gtest/gtest.h"
 #include "test/multiprocess_exec.h"
 #include "test/paths.h"
 #include "util/file/file_io.h"
+#include "util/misc/random_string.h"
 #include "util/net/http_body.h"
 #include "util/net/http_headers.h"
 #include "util/net/http_multipart_builder.h"
 
 namespace crashpad {
 namespace test {
 namespace {
 
 class HTTPTransportTestFixture : public MultiprocessExec {
  public:
@@ skipping 37 matching lines @@
     ASSERT_TRUE(LoggingReadFile(ReadPipeHandle(), &port, sizeof(port)));
 
     // Then the parent will tell the web server what response code to send
     // for the HTTP request.
     ASSERT_TRUE(LoggingWriteFile(
         WritePipeHandle(), &response_code_, sizeof(response_code_)));
 
     // The parent will also tell the web server what response body to send back.
     // The web server will only send the response body if the response code is
     // 200.
-    std::string expect_response_body;
-    for (size_t index = 0; index < 8; ++index) {
-      expect_response_body += static_cast<char>(base::RandInt(' ', '~'));
-    }
+    const std::string random_string = RandomString();
 
     ASSERT_TRUE(LoggingWriteFile(WritePipeHandle(),
-                                 expect_response_body.c_str(),
-                                 expect_response_body.size()));
+                                 random_string.c_str(),
+                                 random_string.size()));
 
     // Now execute the HTTP request.
     scoped_ptr<HTTPTransport> transport(HTTPTransport::Create());
     transport->SetMethod("POST");
     transport->SetURL(base::StringPrintf("http://127.0.0.1:%d/upload", port));
     for (const auto& pair : headers_) {
       transport->SetHeader(pair.first, pair.second);
     }
     transport->SetBodyStream(body_stream_.Pass());
 
     std::string response_body;
     bool success = transport->ExecuteSynchronously(&response_body);
     if (response_code_ == 200) {
       EXPECT_TRUE(success);
-      expect_response_body += "\r\n";
+      std::string expect_response_body = random_string + "\r\n";
       EXPECT_EQ(expect_response_body, response_body);
     } else {
       EXPECT_FALSE(success);
       EXPECT_TRUE(response_body.empty());
     }
 
     // Read until the child's stdout closes.
     std::string request;
     char buf[32];
     FileOperationResult bytes_read;
@@ skipping 182 matching lines @@
 }
 
 TEST(HTTPTransport, Upload33k_LengthUnknown) {
   // The same as Upload33k, but without declaring Content-Length ahead of time.
   RunUpload33k(false);
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad