Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2215)

Unified Diff: build/toolchain/nacl/BUILD.gn

Issue 1451783002: GN: Disable strip in newlib_pnacl_nonsfi toolchain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/nacl/BUILD.gn
diff --git a/build/toolchain/nacl/BUILD.gn b/build/toolchain/nacl/BUILD.gn
index f36fba98afc5e69f33634caa0909febaacee0858..81cb99539950aadb614d24f4174ff3a17fdfaec2 100644
--- a/build/toolchain/nacl/BUILD.gn
+++ b/build/toolchain/nacl/BUILD.gn
@@ -28,7 +28,6 @@ nacl_arm_glibc_rev = revisions[1]
#pnacl_newlib_rev = revisions[2]
template("pnacl_toolchain") {
- assert(defined(invoker.strip), "Must define strip")
assert(defined(invoker.executable_extension),
"Must define executable_extension")
@@ -50,7 +49,9 @@ template("pnacl_toolchain") {
ld = cxx
readelf = toolprefix + "readelf"
nm = toolprefix + "nm"
- strip = toolprefix + invoker.strip
+ if (defined(invoker.strip)) {
+ strip = toolprefix + invoker.strip
+ }
executable_extension = invoker.executable_extension
}
}
@@ -70,8 +71,9 @@ pnacl_toolchain("newlib_pnacl") {
pnacl_toolchain("newlib_pnacl_nonsfi") {
executable_extension = ""
-
- strip = "strip"
+ # TODO(mcgrathr): Uncomment this after pnacl-strip has been taught
+ # to grok --strip-unneeded.
+ #strip = "strip"
}
template("nacl_glibc_toolchain") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698