Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(409)

Issue 145173004: Pass empty email & password to ReadOnlyRietveld in dry run of commit queue (Closed)

Created:
5 years, 10 months ago by Sergey Berezin
Modified:
5 years, 10 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Pass empty email & password to ReadOnlyRietveld in dry run of commit queue This avoids requiring real Rietveld credentials or specifying empty user name on the command line (which is counterintuitive). It also additionally ensures that nothing on Rietveld will change, even if there is a bug in ReadOnlyRietveld wrapper. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=246483

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added the period in a sentence #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M commit_queue.py View 1 1 chunk +4 lines, -6 lines 0 comments Download
M workdir/README View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Berezin
Hi Pawel, please review
5 years, 10 months ago (2014-01-23 01:16:58 UTC) #1
Paweł Hajdan Jr.
LGTM (please note my preferred @chromium.org address - it confusingly has ".jr" in it) https://codereview.chromium.org/145173004/diff/1/commit_queue.py ...
5 years, 10 months ago (2014-01-23 01:26:08 UTC) #2
Sergey Berezin
https://codereview.chromium.org/145173004/diff/1/commit_queue.py File commit_queue.py (right): https://codereview.chromium.org/145173004/diff/1/commit_queue.py#newcode229 commit_queue.py:229: # guarantees rietveld will not allow any changes done
5 years, 10 months ago (2014-01-23 02:00:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyberezin@chromium.org/145173004/60001
5 years, 10 months ago (2014-01-23 02:01:03 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2014-01-23 02:01:22 UTC) #5
Message was sent while issue was closed.
Change committed as 246483

Powered by Google App Engine
This is Rietveld 408576698