Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: commit_queue.py

Issue 145173004: Pass empty email & password to ReadOnlyRietveld in dry run of commit queue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue
Patch Set: Added the period in a sentence Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | workdir/README » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: commit_queue.py
diff --git a/commit_queue.py b/commit_queue.py
index 8bb63acca00fb18d564e6f7449b9ec0e210aeb71..fce6c33ff404223d3ed50917317c4c35993a7ba3 100755
--- a/commit_queue.py
+++ b/commit_queue.py
@@ -224,12 +224,10 @@ def main():
parser.error('--only-issue is not supported with dry run')
else:
print('Using read-only Rietveld')
- # Make sure rietveld is not modified.
- rietveld_obj = rietveld.ReadOnlyRietveld(
- url,
- options.user,
- gaia_creds.get(options.user),
- None)
+ # Make sure rietveld is not modified. Pass empty email and
+ # password to bypass authentication; this additionally
+ # guarantees rietveld will not allow any changes.
+ rietveld_obj = rietveld.ReadOnlyRietveld(url, email='', password='')
else:
AlertOnUncleanCheckout()
print('WARNING: The Commit Queue is going to commit stuff')
« no previous file with comments | « no previous file | workdir/README » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698