chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc - Issue 145153002: Make sideloaded (externally installed) extensions display webstore info

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

Issue 145153002: Make sideloaded (externally installed) extensions display webstore info (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ChromeOS fix Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm ('k') | chrome/browser/ui/views/extensions/extension_install_dialog_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

diff --git a/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc b/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

index af9eae3999b2829dd47f8b4d6d2b9b884aaa8829..c43226465443a526e54dae3c4c042155dd73f9f3 100644

--- a/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

+++ b/chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

@@ -116,6 +116,7 @@ ExtensionInstallDialog::ExtensionInstallDialog(

bool show_retained_files = prompt.GetRetainedFileCount() > 0;

bool is_inline_install =

prompt.type() == ExtensionInstallPrompt::INLINE_INSTALL_PROMPT;

+ bool has_webstore_data = prompt.has_webstore_data();

bool is_bundle_install =

prompt.type() == ExtensionInstallPrompt::BUNDLE_INSTALL_PROMPT;

bool is_external_install =

@@ -198,7 +199,7 @@ ExtensionInstallDialog::ExtensionInstallDialog(

gtk_box_pack_start(GTK_BOX(heading_vbox), heading_label, center_heading,

center_heading, 0);

- if (is_inline_install) {

+ if (has_webstore_data) {

// Average rating (as stars) and number of ratings.

GtkWidget* stars_hbox = gtk_hbox_new(FALSE, 0);

gtk_box_pack_start(GTK_BOX(heading_vbox), stars_hbox, FALSE, FALSE, 0);