chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm - Issue 145153002: Make sideloaded (externally installed) extensions display webstore info

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm

Issue 145153002: Make sideloaded (externally installed) extensions display webstore info (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ChromeOS fix Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm ('k') | chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm

index 12d2b1400614542778e4dd878d0ca4025c4e9d61..c5dcfac5e4249d83979be91a0038eaeaeb75f5a9 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm

@@ -211,7 +211,7 @@ TEST_F(ExtensionInstallViewControllerTest, BasicsInline) {

// No warnings should trigger skinny prompt.

ExtensionInstallPrompt::Prompt inline_prompt(

ExtensionInstallPrompt::INLINE_INSTALL_PROMPT);

- inline_prompt.SetInlineInstallWebstoreData("1,000", true, 3.5, 200);

+ inline_prompt.SetWebstoreData("1,000", true, 3.5, 200);

inline_prompt.set_extension(extension_.get());

inline_prompt.set_icon(chrome::LoadInstallPromptIcon());

@@ -223,7 +223,7 @@ TEST_F(ExtensionInstallViewControllerTest, BasicsInline) {

[controller view]; // Force nib load.

// Test the right nib loaded.

- EXPECT_NSEQ(@"ExtensionInstallPromptInline", [controller nibName]);

+ EXPECT_NSEQ(@"ExtensionInstallPromptWebstoreData", [controller nibName]);

// Check all the controls.

EXPECT_TRUE([controller iconView]);