Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1451373002: Updating mozdownload (excluding tests) (Closed)

Created:
5 years, 1 month ago by phoglund_chromium
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/mozdownload@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Updating mozdownload (excluding tests) We need this to get the WebRTC Firefox interop test back online. Our ancient mozdownload no longer works, but this one appears to work. BUG=545862 R=kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/mozdownload/+/5d3e0bf7851b093ff9a89d45f13185691c496bec

Patch Set 1 #

Total comments: 5

Patch Set 2 : Removed progressbar deps. #

Patch Set 3 : Updated README.md #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1523 lines, -631 lines) Patch
A CONTRIBUTING.md View 1 chunk +18 lines, -0 lines 0 comments Download
A History.md View 1 chunk +204 lines, -0 lines 0 comments Download
D PKG-INFO View 1 chunk +0 lines, -49 lines 0 comments Download
M README.chromium View 1 2 1 chunk +15 lines, -13 lines 0 comments Download
A README.md View 1 chunk +99 lines, -0 lines 0 comments Download
D mozdownload.egg-info/PKG-INFO View 1 chunk +0 lines, -49 lines 0 comments Download
D mozdownload.egg-info/SOURCES.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D mozdownload.egg-info/dependency_links.txt View 1 chunk +0 lines, -1 line 0 comments Download
D mozdownload.egg-info/entry_points.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D mozdownload.egg-info/not-zip-safe View 1 chunk +0 lines, -1 line 0 comments Download
D mozdownload.egg-info/requires.txt View 1 chunk +0 lines, -1 line 0 comments Download
D mozdownload.egg-info/top_level.txt View 1 chunk +0 lines, -1 line 0 comments Download
M mozdownload/__init__.py View 1 1 chunk +20 lines, -1 line 0 comments Download
A mozdownload/cli.py View 1 chunk +174 lines, -0 lines 0 comments Download
A mozdownload/errors.py View 1 chunk +29 lines, -0 lines 0 comments Download
A mozdownload/factory.py View 1 chunk +118 lines, -0 lines 0 comments Download
M mozdownload/parser.py View 3 chunks +52 lines, -13 lines 0 comments Download
M mozdownload/scraper.py View 1 9 chunks +651 lines, -471 lines 0 comments Download
M mozdownload/timezones.py View 2 chunks +0 lines, -3 lines 0 comments Download
A mozdownload/utils.py View 1 chunk +32 lines, -0 lines 0 comments Download
A pylama.ini View 1 chunk +6 lines, -0 lines 0 comments Download
A run_tests.py View 1 chunk +95 lines, -0 lines 0 comments Download
D setup.cfg View 1 chunk +0 lines, -5 lines 0 comments Download
M setup.py View 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
phoglund_chromium
This was done just by deleting the old code and putting the new one in ...
5 years, 1 month ago (2015-11-17 10:07:43 UTC) #2
kjellander_chromium
https://codereview.chromium.org/1451373002/diff/1/mozdownload/scraper.py File mozdownload/scraper.py (right): https://codereview.chromium.org/1451373002/diff/1/mozdownload/scraper.py#newcode16 mozdownload/scraper.py:16: import progressbar as pb Any idea how the script ...
5 years, 1 month ago (2015-11-17 10:19:29 UTC) #4
phoglund_chromium
https://codereview.chromium.org/1451373002/diff/1/mozdownload/scraper.py File mozdownload/scraper.py (right): https://codereview.chromium.org/1451373002/diff/1/mozdownload/scraper.py#newcode16 mozdownload/scraper.py:16: import progressbar as pb On 2015/11/17 10:19:29, kjellander (chromium) ...
5 years, 1 month ago (2015-11-17 11:13:07 UTC) #5
kjellander_chromium
Posted a suggestion. https://codereview.chromium.org/1451373002/diff/1/mozdownload/scraper.py File mozdownload/scraper.py (right): https://codereview.chromium.org/1451373002/diff/1/mozdownload/scraper.py#newcode16 mozdownload/scraper.py:16: import progressbar as pb On 2015/11/17 ...
5 years, 1 month ago (2015-11-17 12:57:17 UTC) #6
phoglund_chromium
PTAL (see differences in patch sets) https://codereview.chromium.org/1451373002/diff/1/mozdownload/scraper.py File mozdownload/scraper.py (right): https://codereview.chromium.org/1451373002/diff/1/mozdownload/scraper.py#newcode16 mozdownload/scraper.py:16: import progressbar as ...
5 years, 1 month ago (2015-11-17 13:47:03 UTC) #7
kjellander_chromium
Awesome! lgtm
5 years, 1 month ago (2015-11-17 16:05:35 UTC) #8
phoglund_chromium
5 years, 1 month ago (2015-11-17 16:22:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5d3e0bf7851b093ff9a89d45f13185691c496bec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698